Fix <1px gap between diff popover and accept keybindingg (#24756)

Agus Zubiaga , Max Brunsfeld , Danilo Leal , rtfeldman , and mgsloan created 11 months ago

Release Notes:

- N/A

Co-authored-by: Max Brunsfeld <[e-mail]>
Co-authored-by: Danilo Leal <[e-mail]>
Co-authored-by: rtfeldman <[e-mail]>
Co-authored-by: mgsloan <[e-mail]>

Change summary

crates/editor/src/element.rs | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

Detailed changes

crates/editor/src/element.rs

@@ -3830,10 +3830,16 @@ impl EditorElement {
                             .h(line_height + BORDER_WIDTH * px(2.))
                             .px_1p5()
                             .gap_1()
-                            .shadow_sm()
+                            // Workaround: For some reason, there's a gap if we don't do this
+                            .ml(-BORDER_WIDTH)
+                            .shadow(smallvec![gpui::BoxShadow {
+                                color: gpui::black().opacity(0.05),
+                                offset: point(px(1.), px(1.)),
+                                blur_radius: px(2.),
+                                spread_radius: px(0.),
+                            }])
                             .bg(Editor::edit_prediction_line_popover_bg_color(cx))
                             .border(BORDER_WIDTH)
-                            .border_l_0()
                             .border_color(cx.theme().colors().border)
                             .rounded_r_lg()
                             .children(editor.render_edit_prediction_accept_keybind(window, cx)),