Remove unnecessary constructor and `Clone` derives

Marshall Bowers created 2 years ago

Change summary

crates/ui2/src/components/context_menu.rs         | 2 +-
crates/ui2/src/components/list/list_separator.rs  | 8 +-------
crates/ui2/src/components/list/list_sub_header.rs | 2 +-
3 files changed, 3 insertions(+), 9 deletions(-)

Detailed changes

crates/ui2/src/components/context_menu.rs

@@ -171,7 +171,7 @@ impl Render for ContextMenu {
                 .child(
                     List::new().children(self.items.iter().enumerate().map(
                         |(ix, item)| match item {
-                            ContextMenuItem::Separator => ListSeparator::new().into_any_element(),
+                            ContextMenuItem::Separator => ListSeparator.into_any_element(),
                             ContextMenuItem::Header(header) => {
                                 ListSubHeader::new(header.clone()).into_any_element()
                             }

crates/ui2/src/components/list/list_separator.rs

@@ -2,15 +2,9 @@ use gpui::Div;
 
 use crate::prelude::*;
 
-#[derive(IntoElement, Clone)]
+#[derive(IntoElement)]
 pub struct ListSeparator;
 
-impl ListSeparator {
-    pub fn new() -> Self {
-        Self
-    }
-}
-
 impl RenderOnce for ListSeparator {
     type Rendered = Div;
 

crates/ui2/src/components/list/list_sub_header.rs

@@ -3,7 +3,7 @@ use gpui::Div;
 use crate::prelude::*;
 use crate::{h_stack, Icon, IconElement, IconSize, Label};
 
-#[derive(IntoElement, Clone)]
+#[derive(IntoElement)]
 pub struct ListSubHeader {
     label: SharedString,
     left_icon: Option<Icon>,