From c826ad2f82016c6925c2ba9e1f2d956c85b973f8 Mon Sep 17 00:00:00 2001 From: Michael Angerman <1809991+stormasm@users.noreply.github.com> Date: Sun, 28 Apr 2024 20:59:21 -0700 Subject: [PATCH] gpui: Improve the image example (#11111) ### fix cropping problem Prior to these changes the images were being cropped so you never actually saw the full image but you had to use your mouse to make the window bigger to see both the text and the images... ### activate ```rust cx.activate(true); ``` was not in place so the window did not appear when you ran the example ### No longer need to Ctrl-c to quit the example Now you can hit *Cmd-q* to quit out of the example instead of having to *Ctrl-c* in your terminal where you fired off the example Release Notes: - N/A --- crates/gpui/examples/image/image.rs | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/crates/gpui/examples/image/image.rs b/crates/gpui/examples/image/image.rs index d6002888c9e8a2d16f70eb7dd599392d0c6a1a5a..32bf205e83b8a674798c95851b2ff1f6f4a0f12e 100644 --- a/crates/gpui/examples/image/image.rs +++ b/crates/gpui/examples/image/image.rs @@ -58,11 +58,36 @@ impl Render for ImageShowcase { } } +actions!(image, [Quit]); + fn main() { env_logger::init(); App::new().run(|cx: &mut AppContext| { - cx.open_window(WindowOptions::default(), |cx| { + cx.activate(true); + cx.on_action(|_: &Quit, cx| cx.quit()); + cx.bind_keys([KeyBinding::new("cmd-q", Quit, None)]); + cx.set_menus(vec![Menu { + name: "Image", + items: vec![MenuItem::action("Quit", Quit)], + }]); + + let window_options = WindowOptions { + titlebar: Some(TitlebarOptions { + title: Some(SharedString::from("Image Example")), + appears_transparent: false, + ..Default::default() + }), + + bounds: Some(Bounds { + size: size(px(1100.), px(600.)).into(), + origin: Point::new(DevicePixels::from(200), DevicePixels::from(200)), + }), + + ..Default::default() + }; + + cx.open_window(window_options, |cx| { cx.new_view(|_cx| ImageShowcase { // Relative path to your root project path local_resource: Arc::new(PathBuf::from_str("examples/image/app-icon.png").unwrap()),