Audit all TODOs in Zed and mark port related todos

Mikayla created 2 years ago

Change summary

crates/call/src/call.rs               | 3 ++-
crates/editor/src/element.rs          | 1 -
crates/file_finder/src/file_finder.rs | 2 +-
crates/gpui/src/action.rs             | 1 +
4 files changed, 4 insertions(+), 3 deletions(-)

Detailed changes

crates/call/src/call.rs

@@ -239,7 +239,8 @@ impl ActiveCall {
             if result.is_ok() {
                 this.update(&mut cx, |this, cx| this.report_call_event("invite", cx))?;
             } else {
-                // TODO: Resport collaboration error
+                //TODO: report collaboration error
+                log::error!("invite failed: {:?}", result);
             }
 
             this.update(&mut cx, |this, cx| {

crates/editor/src/element.rs

@@ -1010,7 +1010,6 @@ impl EditorElement {
                                         .chars_at(cursor_position)
                                         .next()
                                         .and_then(|(character, _)| {
-                                            // todo!() currently shape_line panics if text conatins newlines
                                             let text = if character == '\n' {
                                                 SharedString::from(" ")
                                             } else {

crates/file_finder/src/file_finder.rs

@@ -312,7 +312,7 @@ impl FileFinderDelegate {
         cx: &mut ViewContext<FileFinder>,
     ) -> Self {
         cx.observe(&project, |file_finder, _, cx| {
-            //todo!() We should probably not re-render on every project anything
+            //todo We should probably not re-render on every project anything
             file_finder
                 .picker
                 .update(cx, |picker, cx| picker.refresh(cx))

crates/gpui/src/action.rs

@@ -128,6 +128,7 @@ impl ActionRegistry {
     }
 
     fn insert_action(&mut self, action: ActionData) {
+        //todo!(remove)
         let name: SharedString = action.name.into();
         self.builders_by_name.insert(name.clone(), action.build);
         self.names_by_type_id.insert(action.type_id, name.clone());