Enable `clippy::needless_borrowed_reference` (#8746)

Marshall Bowers created 2 years ago

This PR enables the
[`clippy::needless_borrowed_reference`](https://rust-lang.github.io/rust-clippy/master/index.html#/needless_borrowed_reference)
rule and fixes the outstanding violations.

Release Notes:

- N/A

Change summary

crates/editor/src/element.rs | 2 +-
tooling/xtask/src/main.rs    | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)

Detailed changes

crates/editor/src/element.rs

@@ -3273,7 +3273,7 @@ impl PositionMap {
         let (column, x_overshoot_after_line_end) = if let Some(line) = self
             .line_layouts
             .get(row as usize - scroll_position.y as usize)
-            .map(|&LineWithInvisibles { ref line, .. }| line)
+            .map(|LineWithInvisibles { line, .. }| line)
         {
             if let Some(ix) = line.index_for_x(x) {
                 (ix as u32, px(0.))

tooling/xtask/src/main.rs

@@ -100,7 +100,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
         "clippy::iter_overeager_cloned",
         "clippy::let_underscore_future",
         "clippy::map_entry",
-        "clippy::needless_borrowed_reference",
         "clippy::needless_lifetimes",
         "clippy::needless_option_as_deref",
         "clippy::needless_question_mark",