From cbc8394afb0798e3538a6419e0e14945ba98583b Mon Sep 17 00:00:00 2001 From: Guillaume Launay Date: Sun, 27 Jul 2025 15:36:53 +0200 Subject: [PATCH] Better error message git --- crates/git/src/repository.rs | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/crates/git/src/repository.rs b/crates/git/src/repository.rs index 8b174aeec33b506c8b56bc6b35cd8d6fff6dbd95..468e33152667628a164c1bdb2d0d0d8316d019b3 100644 --- a/crates/git/src/repository.rs +++ b/crates/git/src/repository.rs @@ -1109,7 +1109,7 @@ impl GitRepository for RealGitRepository { { Ok(_) => anyhow::Ok(()), Err(e) => { - if let Some(git_error) = e.downcast_ref::() { + if let Some(git_error) = e.downcast_ref::() { anyhow::bail!("{}", git_error.stderr.trim()); } Err(e) @@ -1144,7 +1144,7 @@ impl GitRepository for RealGitRepository { { Ok(_) => Ok(()), Err(e) => { - if let Some(git_error) = e.downcast_ref::() { + if let Some(git_error) = e.downcast_ref::() { anyhow::bail!("{}", git_error.stderr.trim()); } Err(e) @@ -1881,7 +1881,7 @@ impl GitBinary { let stderr = String::from_utf8_lossy(&output.stderr).to_string(); if !output.status.success() { - return Err(GitBranchCommandError { + return Err(GitBinaryCommandError { stdout: stdout.clone(), stderr: stderr.clone(), status: output.status, @@ -1933,14 +1933,6 @@ struct GitBinaryCommandError { status: ExitStatus, } -#[derive(Error, Debug)] -#[error("Git branch command failed: {}", .stderr.trim().if_empty(.stdout.trim()))] -struct GitBranchCommandError { - stdout: String, - stderr: String, - status: ExitStatus, -} - trait StringExt { fn if_empty<'a>(&'a self, fallback: &'a str) -> &'a str; }