From cc9317525631e6bf88672e716d6188814f55968a Mon Sep 17 00:00:00 2001 From: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Date: Tue, 5 Aug 2025 20:11:43 -0300 Subject: [PATCH] Recategorize a few items in the component preview (#35681) Release Notes: - N/A --- crates/agent_ui/src/ui/end_trial_upsell.rs | 10 ++++++---- crates/ai_onboarding/src/ai_onboarding.rs | 10 +++++++++- crates/ai_onboarding/src/ai_upsell_card.rs | 2 +- crates/component/src/component.rs | 2 ++ crates/language_models/src/provider/cloud.rs | 10 +++++++++- crates/onboarding/src/theme_preview.rs | 12 ++++++++++++ crates/ui/src/components/banner.rs | 2 +- crates/ui/src/components/callout.rs | 2 +- crates/ui/src/components/tab.rs | 2 +- crates/ui/src/styles/animation.rs | 2 +- crates/ui/src/styles/color.rs | 2 +- 11 files changed, 44 insertions(+), 12 deletions(-) diff --git a/crates/agent_ui/src/ui/end_trial_upsell.rs b/crates/agent_ui/src/ui/end_trial_upsell.rs index 0d9751afecbe6b2569984cab80b645ce5a757ac7..3a8a119800543ad033efd563d7896ccc80add373 100644 --- a/crates/agent_ui/src/ui/end_trial_upsell.rs +++ b/crates/agent_ui/src/ui/end_trial_upsell.rs @@ -94,18 +94,20 @@ impl RenderOnce for EndTrialUpsell { impl Component for EndTrialUpsell { fn scope() -> ComponentScope { - ComponentScope::Agent + ComponentScope::Onboarding + } + + fn name() -> &'static str { + "End of Trial Upsell Banner" } fn sort_name() -> &'static str { - "AgentEndTrialUpsell" + "End of Trial Upsell Banner" } fn preview(_window: &mut Window, _cx: &mut App) -> Option { Some( v_flex() - .p_4() - .gap_4() .child(EndTrialUpsell { dismiss_upsell: Arc::new(|_, _| {}), }) diff --git a/crates/ai_onboarding/src/ai_onboarding.rs b/crates/ai_onboarding/src/ai_onboarding.rs index 9372a33fedb3ff59c4ff149c004f0b48e212cc68..b9a1e49a4acdfb3f4a94b6313d1e6fb3ef969adc 100644 --- a/crates/ai_onboarding/src/ai_onboarding.rs +++ b/crates/ai_onboarding/src/ai_onboarding.rs @@ -368,7 +368,15 @@ impl RenderOnce for ZedAiOnboarding { impl Component for ZedAiOnboarding { fn scope() -> ComponentScope { - ComponentScope::Agent + ComponentScope::Onboarding + } + + fn name() -> &'static str { + "Agent Panel Banners" + } + + fn sort_name() -> &'static str { + "Agent Panel Banners" } fn preview(_window: &mut Window, _cx: &mut App) -> Option { diff --git a/crates/ai_onboarding/src/ai_upsell_card.rs b/crates/ai_onboarding/src/ai_upsell_card.rs index a3fea5dce32d03609e7eba89ca6969e55fec3c4c..4e4833f7700ed22f3c7ce86db38143b45ac8765b 100644 --- a/crates/ai_onboarding/src/ai_upsell_card.rs +++ b/crates/ai_onboarding/src/ai_upsell_card.rs @@ -236,7 +236,7 @@ impl RenderOnce for AiUpsellCard { impl Component for AiUpsellCard { fn scope() -> ComponentScope { - ComponentScope::Agent + ComponentScope::Onboarding } fn name() -> &'static str { diff --git a/crates/component/src/component.rs b/crates/component/src/component.rs index 02840cc3cb922f2e8a37c5985db529f66d7791b0..0c05ba4a97f4598e9f7982cbc294831a955f1fc6 100644 --- a/crates/component/src/component.rs +++ b/crates/component/src/component.rs @@ -318,8 +318,10 @@ pub enum ComponentScope { Notification, #[strum(serialize = "Overlays & Layering")] Overlays, + Onboarding, Status, Typography, + Utilities, #[strum(serialize = "Version Control")] VersionControl, } diff --git a/crates/language_models/src/provider/cloud.rs b/crates/language_models/src/provider/cloud.rs index 2108547c4f839ffc672292b75b8b751e66904b11..134b2bef6c79fa5de356fe9742a0a905bf1c8057 100644 --- a/crates/language_models/src/provider/cloud.rs +++ b/crates/language_models/src/provider/cloud.rs @@ -1267,8 +1267,16 @@ impl Render for ConfigurationView { } impl Component for ZedAiConfiguration { + fn name() -> &'static str { + "AI Configuration Content" + } + + fn sort_name() -> &'static str { + "AI Configuration Content" + } + fn scope() -> ComponentScope { - ComponentScope::Agent + ComponentScope::Onboarding } fn preview(_window: &mut Window, _cx: &mut App) -> Option { diff --git a/crates/onboarding/src/theme_preview.rs b/crates/onboarding/src/theme_preview.rs index 53631be1c9b1a5455630ad3113919fcf96c6ec1e..81eb14ec4b0cb502618c8bd06d4cd92a63186c71 100644 --- a/crates/onboarding/src/theme_preview.rs +++ b/crates/onboarding/src/theme_preview.rs @@ -299,6 +299,18 @@ impl RenderOnce for ThemePreviewTile { } impl Component for ThemePreviewTile { + fn scope() -> ComponentScope { + ComponentScope::Onboarding + } + + fn name() -> &'static str { + "Theme Preview Tile" + } + + fn sort_name() -> &'static str { + "Theme Preview Tile" + } + fn description() -> Option<&'static str> { Some(Self::DOCS) } diff --git a/crates/ui/src/components/banner.rs b/crates/ui/src/components/banner.rs index b16ca795b4b0c6f0ef4332d54f3db75ae8e42103..d88905d4664f83ff985cb6b4226ae9c6b43ebe91 100644 --- a/crates/ui/src/components/banner.rs +++ b/crates/ui/src/components/banner.rs @@ -131,7 +131,7 @@ impl RenderOnce for Banner { impl Component for Banner { fn scope() -> ComponentScope { - ComponentScope::Notification + ComponentScope::DataDisplay } fn preview(_window: &mut Window, _cx: &mut App) -> Option { diff --git a/crates/ui/src/components/callout.rs b/crates/ui/src/components/callout.rs index d15fa122ed95e5e9a922c8bc694d1c35d975f9a4..9c1c9fb1a9d7b5b603bd3c55b64b19375b6b521e 100644 --- a/crates/ui/src/components/callout.rs +++ b/crates/ui/src/components/callout.rs @@ -158,7 +158,7 @@ impl RenderOnce for Callout { impl Component for Callout { fn scope() -> ComponentScope { - ComponentScope::Notification + ComponentScope::DataDisplay } fn description() -> Option<&'static str> { diff --git a/crates/ui/src/components/tab.rs b/crates/ui/src/components/tab.rs index a205c33358eb7ac46d81572948a3165967b734d6..d704846a6834e094a6a6aeb5fcf1fda6ea66c8b2 100644 --- a/crates/ui/src/components/tab.rs +++ b/crates/ui/src/components/tab.rs @@ -179,7 +179,7 @@ impl RenderOnce for Tab { impl Component for Tab { fn scope() -> ComponentScope { - ComponentScope::None + ComponentScope::Navigation } fn description() -> Option<&'static str> { diff --git a/crates/ui/src/styles/animation.rs b/crates/ui/src/styles/animation.rs index 0649bee1f82b666a5fd187fa84aeba45ede36f8a..ee5352d45403183555fe8d6c72806a5b90f88ca8 100644 --- a/crates/ui/src/styles/animation.rs +++ b/crates/ui/src/styles/animation.rs @@ -99,7 +99,7 @@ struct Animation {} impl Component for Animation { fn scope() -> ComponentScope { - ComponentScope::None + ComponentScope::Utilities } fn description() -> Option<&'static str> { diff --git a/crates/ui/src/styles/color.rs b/crates/ui/src/styles/color.rs index c7b995d39afc67d2441eeeae36832451ae071af7..586b2ccc576fc6321e95cd530d4703fa95b3c36f 100644 --- a/crates/ui/src/styles/color.rs +++ b/crates/ui/src/styles/color.rs @@ -126,7 +126,7 @@ impl From for Color { impl Component for Color { fn scope() -> ComponentScope { - ComponentScope::None + ComponentScope::Utilities } fn description() -> Option<&'static str> {