Don't use test-only method; add ctrl-j binding

Nathan Sobo and Conrad Irwin created 2 years ago

Co-Authored-By: Conrad Irwin <[e-mail]>

Change summary

assets/keymaps/default.json | 1 +
crates/editor/src/editor.rs | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)

Detailed changes

assets/keymaps/default.json

@@ -411,6 +411,7 @@
       "ctrl-shift-k": "editor::DeleteLine",
       "cmd-shift-d": "editor::DuplicateLine",
       "cmd-shift-l": "editor::SplitSelectionIntoLines",
+      "ctrl-j": "editor::JoinLines",
       "ctrl-cmd-up": "editor::MoveLineUp",
       "ctrl-cmd-down": "editor::MoveLineDown",
       "ctrl-alt-backspace": "editor::DeleteToPreviousSubwordStart",

crates/editor/src/editor.rs

@@ -3956,7 +3956,7 @@ impl Editor {
 
     pub fn join_lines(&mut self, _: &JoinLines, cx: &mut ViewContext<Self>) {
         let mut row_ranges = Vec::<Range<u32>>::new();
-        for selection in self.selections.ranges::<Point>(cx) {
+        for selection in self.selections.all::<Point>(cx) {
             let start = selection.start.row;
             let end = if selection.start.row == selection.end.row {
                 selection.start.row + 1