From ce696c18ed7ee26f5dda159860b887c1f195ad41 Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Tue, 14 Oct 2025 10:32:25 -0600 Subject: [PATCH] Remove ping/unwrap from crash handler (#39870) Release Notes: - N/A --------- Co-authored-by: Julia Ryan --- crates/crashes/src/crashes.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/crates/crashes/src/crashes.rs b/crates/crashes/src/crashes.rs index 4c8c6ec45e621862115ef6441857ada4e2b634ad..4a45961970cf009ef2a47d5562c1df1792a90aec 100644 --- a/crates/crashes/src/crashes.rs +++ b/crates/crashes/src/crashes.rs @@ -92,7 +92,10 @@ pub async fn init(crash_init: InitCrashHandler) { #[cfg(target_os = "macos")] suspend_all_other_threads(); - client.ping().unwrap(); + // on macos this "ping" is needed to ensure that all our + // `client.send_message` calls have been processed before we trigger the + // minidump request. + client.ping().ok(); client.request_dump(crash_context).is_ok() } else { true