Make `BlockMap` randomized test pass in low-complexity cases

Antonio Scandurra and Nathan Sobo created 4 years ago

Co-Authored-By: Nathan Sobo <[e-mail]>

Change summary

crates/buffer/src/rope.rs                  | 10 ------
crates/editor/src/display_map/block_map.rs | 38 ++++++++++++------------
2 files changed, 19 insertions(+), 29 deletions(-)

Detailed changes

crates/buffer/src/rope.rs

@@ -94,16 +94,6 @@ impl Rope {
         self.append(suffix);
     }
 
-    pub fn starts_with(&self, text: &str) -> bool {
-        self.chunks().flat_map(|c| c.bytes()).eq(text.bytes())
-    }
-
-    pub fn ends_with(&self, text: &str) -> bool {
-        self.reversed_chunks_in_range(0..self.len())
-            .flat_map(|c| c.bytes().rev())
-            .eq(text.bytes().rev())
-    }
-
     fn check_invariants(&self) {
         #[cfg(test)]
         {

crates/editor/src/display_map/block_map.rs

@@ -189,20 +189,24 @@ impl BlockMap {
 
             dbg!("expanded edit", &edit);
             let start_anchor = buffer.anchor_before(Point::new(edit.new.start, 0));
-            let end_anchor = buffer.anchor_before(Point::new(edit.new.end, 0));
             let start_block_ix = match self.blocks[last_block_ix..]
                 .binary_search_by(|probe| probe.position.cmp(&start_anchor, buffer).unwrap())
             {
                 Ok(ix) | Err(ix) => last_block_ix + ix,
             };
-            let end_block_ix = match self.blocks[start_block_ix..].binary_search_by(|probe| {
-                probe
-                    .position
-                    .cmp(&end_anchor, buffer)
-                    .unwrap()
-                    .then(Ordering::Greater)
-            }) {
-                Ok(ix) | Err(ix) => start_block_ix + ix,
+            let end_block_ix = if edit.new.end > wrap_snapshot.max_point().row() {
+                self.blocks.len()
+            } else {
+                let end_anchor = buffer.anchor_before(Point::new(edit.new.end, 0));
+                match self.blocks[start_block_ix..].binary_search_by(|probe| {
+                    probe
+                        .position
+                        .cmp(&end_anchor, buffer)
+                        .unwrap()
+                        .then(Ordering::Greater)
+                }) {
+                    Ok(ix) | Err(ix) => start_block_ix + ix,
+                }
             };
             last_block_ix = end_block_ix;
 
@@ -240,10 +244,9 @@ impl BlockMap {
             }
 
             let new_transforms_end = new_transforms.summary().input;
-            if new_transforms_end.row < edit.new.end - 1 {
-                // TODO: Should we just report the wrap edits in 2d so we can skip this max point check?
-                let edit_new_end_point =
-                    cmp::min(Point::new(edit.new.end, 0), wrap_snapshot.max_point().0);
+            let edit_new_end_point =
+                cmp::min(Point::new(edit.new.end, 0), wrap_snapshot.max_point().0);
+            if new_transforms_end < edit_new_end_point {
                 new_transforms.push(
                     Transform::isomorphic(edit_new_end_point - new_transforms_end),
                     &(),
@@ -306,13 +309,9 @@ impl<'a> BlockMapWriter<'a> {
             };
             let mut text = block.text.into();
             if block.disposition.is_above() {
-                if !text.ends_with("\n") {
-                    text.push("\n");
-                }
+                text.push("\n");
             } else {
-                if !text.starts_with("\n") {
-                    text.push_front("\n");
-                }
+                text.push_front("\n");
             }
 
             self.0.blocks.insert(
@@ -745,6 +744,7 @@ mod tests {
         let buffer = cx.add_model(|cx| {
             let len = rng.gen_range(0..10);
             let text = RandomCharIter::new(&mut rng).take(len).collect::<String>();
+            log::info!("initial buffer text: {:?}", text);
             Buffer::new(0, text, cx)
         });
         let (fold_map, folds_snapshot) = FoldMap::new(buffer.clone(), cx);