From cfa478dde414e008138c1d8ec54c015ed3af47d6 Mon Sep 17 00:00:00 2001 From: Xiaobo Liu Date: Thu, 8 Jan 2026 18:01:42 +0800 Subject: [PATCH] windows: Improve error message for credential write failures (#46221) Release Notes: - Improved Display the actual Windows error message when writing credentials to Credential Manager fails, instead of the generic "Failed to write API key to keychain" message. This helps users diagnose issues like permission problems. Signed-off-by: Xiaobo Liu --- crates/gpui/src/platform/windows/platform.rs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/crates/gpui/src/platform/windows/platform.rs b/crates/gpui/src/platform/windows/platform.rs index 3da902f6abab0cefb658ef17be45e34ae6d218ab..113a9c08a4871acf05e503c99439f30cb7270b2a 100644 --- a/crates/gpui/src/platform/windows/platform.rs +++ b/crates/gpui/src/platform/windows/platform.rs @@ -635,7 +635,14 @@ impl Platform for WindowsPlatform { UserName: PWSTR::from_raw(username.as_mut_ptr()), ..CREDENTIALW::default() }; - unsafe { CredWriteW(&credentials, 0) }?; + unsafe { + CredWriteW(&credentials, 0).map_err(|err| { + anyhow!( + "Failed to write credentials to Windows Credential Manager: {}", + err, + ) + })?; + } Ok(()) }) }