Swap `agent.single_file_review`'s default value to false (#48619)

Mikayla Maki created 2 months ago

Release Notes:

- Swapped the default value for `agent.single_file_review` to `false`.
Agent diffs will no longer override the git diff in your buffer. You can
still review the agent's changes via the action log review button, or by
flipping this setting back to `true`

Change summary

assets/settings/default.json      |  2 +-
crates/agent_ui/src/agent_diff.rs | 11 ++++++++++-
2 files changed, 11 insertions(+), 2 deletions(-)

Detailed changes

assets/settings/default.json

@@ -1000,7 +1000,7 @@
       },
     },
     // When enabled, agent edits will be displayed in single-file editors for review
-    "single_file_review": true,
+    "single_file_review": false,
     // When enabled, show voting thumbs for feedback on agent edits.
     "enable_feedback": true,
     "default_profile": "write",

crates/agent_ui/src/agent_diff.rs

@@ -1726,6 +1726,7 @@ mod tests {
     use super::*;
     use crate::Keep;
     use acp_thread::AgentConnection as _;
+    use agent_settings::AgentSettings;
     use editor::EditorSettings;
     use gpui::{TestAppContext, UpdateGlobal, VisualTestContext};
     use project::{FakeFs, Project};
@@ -1889,7 +1890,7 @@ mod tests {
     }
 
     #[gpui::test]
-    async fn test_singleton_agent_diff(cx: &mut TestAppContext) {
+    async fn test_single_file_review_diff(cx: &mut TestAppContext) {
         cx.update(|cx| {
             let settings_store = SettingsStore::test(cx);
             cx.set_global(settings_store);
@@ -1899,6 +1900,14 @@ mod tests {
             workspace::register_project_item::<Editor>(cx);
         });
 
+        cx.update(|cx| {
+            SettingsStore::update_global(cx, |store, _cx| {
+                let mut agent_settings = store.get::<AgentSettings>(None).clone();
+                agent_settings.single_file_review = true;
+                store.override_global(agent_settings);
+            });
+        });
+
         let fs = FakeFs::new(cx.executor());
         fs.insert_tree(
             path!("/test"),