Another pass of #[allow()] removal (#3825)

Piotr Osiewicz created 2 years ago

We still have a bunch of leftovers in ui2/theme2 and in gpui2
display_link module.

Release Notes:

- N/A

Change summary

crates/collab2/src/tests/test_server.rs |  2 -
crates/copilot2/src/copilot2.rs         |  2 -
crates/gpui2/src/platform/mac.rs        | 32 ++------------------------
crates/gpui2/src/platform/mac/events.rs |  2 -
crates/gpui2/src/platform/mac/window.rs |  1 
crates/gpui2/src/scene.rs               |  1 
crates/text2/src/text2.rs               |  3 --
7 files changed, 3 insertions(+), 40 deletions(-)

Detailed changes

crates/collab2/src/tests/test_server.rs

@@ -260,8 +260,6 @@ impl TestServer {
             .store(true, SeqCst);
     }
 
-    //todo!(workspace)
-    #[allow(dead_code)]
     pub fn simulate_long_connection_interruption(
         &self,
         peer_id: PeerId,

crates/copilot2/src/copilot2.rs

@@ -563,7 +563,6 @@ impl Copilot {
         }
     }
 
-    #[allow(dead_code)] // todo!()
     fn sign_out(&mut self, cx: &mut ModelContext<Self>) -> Task<Result<()>> {
         self.update_sign_in_status(request::SignInStatus::NotSignedIn, cx);
         if let CopilotServer::Running(RunningCopilotServer { lsp: server, .. }) = &self.server {
@@ -1126,7 +1125,6 @@ mod tests {
             .update(cx, |copilot, cx| copilot.sign_out(cx))
             .await
             .unwrap();
-        // todo!() po: these notifications now happen in reverse order?
         assert_eq!(
             lsp.receive_notification::<lsp::notification::DidCloseTextDocument>()
                 .await,

crates/gpui2/src/platform/mac.rs

@@ -13,23 +13,13 @@ mod window;
 mod window_appearence;
 
 use crate::{px, size, GlobalPixels, Pixels, Size};
-use anyhow::anyhow;
 use cocoa::{
     base::{id, nil},
-    foundation::{NSAutoreleasePool, NSNotFound, NSRect, NSSize, NSString, NSUInteger, NSURL},
+    foundation::{NSAutoreleasePool, NSNotFound, NSRect, NSSize, NSString, NSUInteger},
 };
 use metal_renderer::*;
-use objc::{
-    msg_send,
-    runtime::{BOOL, NO, YES},
-    sel, sel_impl,
-};
-use std::{
-    ffi::{c_char, CStr, OsStr},
-    ops::Range,
-    os::unix::prelude::OsStrExt,
-    path::PathBuf,
-};
+use objc::runtime::{BOOL, NO, YES};
+use std::ops::Range;
 
 pub use dispatcher::*;
 pub use display::*;
@@ -147,19 +137,3 @@ impl From<NSRect> for Size<GlobalPixels> {
 //             && self.origin.y + self.size.height >= other.origin.y
 //     }
 // }
-
-// todo!
-#[allow(unused)]
-unsafe fn ns_url_to_path(url: id) -> crate::Result<PathBuf> {
-    let path: *mut c_char = msg_send![url, fileSystemRepresentation];
-    if path.is_null() {
-        Err(anyhow!(
-            "url is not a file path: {}",
-            CStr::from_ptr(url.absoluteString().UTF8String()).to_string_lossy()
-        ))
-    } else {
-        Ok(PathBuf::from(OsStr::from_bytes(
-            CStr::from_ptr(path).to_bytes(),
-        )))
-    }
-}

crates/gpui2/src/platform/mac/events.rs

@@ -34,8 +34,6 @@ unsafe fn build_event_source() {
     mem::forget(source);
 }
 
-// todo!
-#[allow(unused)]
 pub fn key_to_native(key: &str) -> Cow<str> {
     use cocoa::appkit::*;
     let code = match key {

crates/gpui2/src/platform/mac/window.rs

@@ -74,7 +74,6 @@ const NSWindowAnimationBehaviorUtilityWindow: NSInteger = 4;
 #[allow(non_upper_case_globals)]
 const NSViewLayerContentsRedrawDuringViewResize: NSInteger = 2;
 // https://developer.apple.com/documentation/appkit/nsdragoperation
-#[allow(non_upper_case_globals)]
 type NSDragOperation = NSUInteger;
 #[allow(non_upper_case_globals)]
 const NSDragOperationNone: NSDragOperation = 0;

crates/gpui2/src/scene.rs

@@ -172,7 +172,6 @@ pub struct Scene {
 }
 
 impl Scene {
-    #[allow(dead_code)]
     pub fn paths(&self) -> &[Path<ScaledPixels>] {
         &self.paths
     }

crates/text2/src/text2.rs

@@ -1189,7 +1189,6 @@ impl Buffer {
         self.undo_or_redo(transaction).log_err()
     }
 
-    #[allow(clippy::needless_collect)]
     pub fn undo_to_transaction(&mut self, transaction_id: TransactionId) -> Vec<Operation> {
         let transactions = self
             .history
@@ -1223,7 +1222,6 @@ impl Buffer {
         }
     }
 
-    #[allow(clippy::needless_collect)]
     pub fn redo_to_transaction(&mut self, transaction_id: TransactionId) -> Vec<Operation> {
         let transactions = self
             .history
@@ -1536,7 +1534,6 @@ impl Buffer {
         edits
     }
 
-    #[allow(clippy::type_complexity)]
     pub fn randomly_edit<T>(
         &mut self,
         rng: &mut T,