Enable `clippy::redundant_locals` (#8750)

Marshall Bowers created 2 years ago

This PR enables the
[`clippy::redundant_locals`](https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_locals)
rule and fixes the outstanding violations.

Release Notes:

- N/A

Change summary

crates/editor/src/editor.rs                  | 1 -
crates/rpc/src/conn.rs                       | 1 -
crates/semantic_index/src/semantic_index.rs  | 1 -
crates/terminal_view/src/terminal_element.rs | 1 -
crates/workspace/src/workspace.rs            | 1 -
tooling/xtask/src/main.rs                    | 1 -
6 files changed, 6 deletions(-)

Detailed changes

crates/editor/src/editor.rs

@@ -8810,7 +8810,6 @@ impl Editor {
                     Ok(i) | Err(i) => i,
                 };
 
-                let right_position = right_position;
                 ranges[start_ix..]
                     .iter()
                     .take_while(move |range| range.start.cmp(&right_position, buffer).is_le())

crates/rpc/src/conn.rs

@@ -84,7 +84,6 @@ impl Connection {
             });
 
             let rx = rx.then({
-                let killed = killed;
                 let executor = executor.clone();
                 move |msg| {
                     let killed = killed.clone();

crates/semantic_index/src/semantic_index.rs

@@ -840,7 +840,6 @@ impl SemanticIndex {
             let mut batch_results = Vec::new();
             for batch in file_ids.chunks(batch_size) {
                 let batch = batch.into_iter().map(|v| *v).collect::<Vec<i64>>();
-                let limit = limit;
                 let fs = fs.clone();
                 let db_path = db_path.clone();
                 let query = query.clone();

crates/terminal_view/src/terminal_element.rs

@@ -645,7 +645,6 @@ impl TerminalElement {
         });
 
         cx.on_mouse_event({
-            let bounds = bounds;
             let focus = self.focus.clone();
             let terminal = self.terminal.clone();
             move |e: &MouseMoveEvent, phase, cx| {

crates/workspace/src/workspace.rs

@@ -871,7 +871,6 @@ impl Workspace {
 
                 cx.open_window(options, {
                     let app_state = app_state.clone();
-                    let workspace_id = workspace_id;
                     let project_handle = project_handle.clone();
                     move |cx| {
                         cx.new_view(|cx| {

tooling/xtask/src/main.rs

@@ -111,7 +111,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
         "clippy::option_map_unit_fn",
         "clippy::redundant_closure_call",
         "clippy::redundant_guards",
-        "clippy::redundant_locals",
         "clippy::reversed_empty_ranges",
         "clippy::single_range_in_vec_init",
         "clippy::suspicious_to_owned",