From d295c46433670118273c6c2b08e2416e13730ec9 Mon Sep 17 00:00:00 2001 From: "Joseph T. Lyons" Date: Tue, 8 Oct 2024 11:10:20 -0400 Subject: [PATCH] Remove deprecated copilot event (#18862) `CopilotEvent` was succeeded by `InlineCompletionEvent` 5 months ago. Release Notes: - N/A --- crates/collab/src/api/events.rs | 2 -- crates/telemetry_events/src/telemetry_events.rs | 10 ---------- 2 files changed, 12 deletions(-) diff --git a/crates/collab/src/api/events.rs b/crates/collab/src/api/events.rs index f5cd1c00eae4175a0196e42b9fcbdf01fb79f2cb..5d40c59daf548c01008d44106eefc1fe561916cc 100644 --- a/crates/collab/src/api/events.rs +++ b/crates/collab/src/api/events.rs @@ -429,8 +429,6 @@ pub async fn post_events( country_code.clone(), checksum_matched, )), - // Needed for clients sending old copilot_event types - Event::Copilot(_) => {} Event::InlineCompletion(event) => { to_upload .inline_completion_events diff --git a/crates/telemetry_events/src/telemetry_events.rs b/crates/telemetry_events/src/telemetry_events.rs index a42b8cc8b5d80805ef727a9727c9e32a0079bd60..32cb377ed616ab800191784220ab563ab7ab2746 100644 --- a/crates/telemetry_events/src/telemetry_events.rs +++ b/crates/telemetry_events/src/telemetry_events.rs @@ -91,7 +91,6 @@ impl Display for AssistantPhase { #[serde(tag = "type")] pub enum Event { Editor(EditorEvent), - Copilot(CopilotEvent), // Needed for clients sending old copilot_event types InlineCompletion(InlineCompletionEvent), Call(CallEvent), Assistant(AssistantEvent), @@ -121,15 +120,6 @@ pub struct EditorEvent { pub is_via_ssh: bool, } -/// Deprecated since Zed v0.137.0 (2024-05-29). Replaced by InlineCompletionEvent. -// Needed for clients sending old copilot_event types -#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)] -pub struct CopilotEvent { - pub suggestion_id: Option, - pub suggestion_accepted: bool, - pub file_extension: Option, -} - #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)] pub struct InlineCompletionEvent { /// Provider of the completion suggestion (e.g. copilot, supermaven)