From d4531af8aaffd2cf7226439ecd179c26e57f75d4 Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Mon, 3 Feb 2025 22:44:07 -0700 Subject: [PATCH] Invalidate GPUI views regardless of draw phase (#24164) We think this could fix issues around view invalidation during focus handling. I want to run CI on this and see. cc @mikayla-maki @maxbrunsfeld Release Notes: - N/A --- crates/gpui/src/window.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/gpui/src/window.rs b/crates/gpui/src/window.rs index 3cb84102a707af00a6b564468e9f9bfd5d3d79d6..7e0fae8cc4b2a8c3dde73bb80b62f18ca498d534 100644 --- a/crates/gpui/src/window.rs +++ b/crates/gpui/src/window.rs @@ -107,9 +107,9 @@ impl WindowInvalidator { pub fn invalidate_view(&self, entity: EntityId, cx: &mut App) -> bool { let mut inner = self.inner.borrow_mut(); + inner.dirty_views.insert(entity); if inner.draw_phase == DrawPhase::None { inner.dirty = true; - inner.dirty_views.insert(entity); cx.push_effect(Effect::Notify { emitter: entity }); true } else {