Drop window borrow before calling `makeKeyAndOrderFront`

Antonio Scandurra created 3 years ago

We're seeing some stack traces where calling `makeKeyAndOrderFront`
could invoke `setFrameSize`, which is causing a double borrow.

Change summary

crates/gpui/src/platform/mac/window.rs | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Detailed changes

crates/gpui/src/platform/mac/window.rs

@@ -402,7 +402,8 @@ impl platform::Window for Window {
     }
 
     fn activate(&self) {
-        unsafe { msg_send![self.0.borrow().native_window, makeKeyAndOrderFront: nil] }
+        let window = self.0.borrow().native_window;
+        unsafe { msg_send![window, makeKeyAndOrderFront: nil] }
     }
 
     fn set_title(&mut self, title: &str) {