edit predictions: Rename edit prediction modes (#25657)

Agus Zubiaga and Danilo Leal created 10 months ago

`auto` -> `stealth`
`eager_preview` -> `eager`

Release Notes:

- N/A

---------

Co-authored-by: Danilo Leal <[e-mail]>

Change summary

assets/settings/default.json                                    | 10 +-
crates/editor/src/editor.rs                                     |  2 
crates/inline_completion_button/src/inline_completion_button.rs |  8 +-
crates/language/src/language_settings.rs                        |  5 
4 files changed, 13 insertions(+), 12 deletions(-)

Detailed changes

assets/settings/default.json

@@ -840,11 +840,11 @@
     ],
     // When to show edit predictions previews in buffer.
     // This setting takes two possible values:
-    // 1. Display inline when there are no language server completions available.
-    //     "mode": "eager_preview"
-    // 2. Display inline when holding modifier key (alt by default).
-    //     "mode": "auto"
-    "mode": "eager_preview"
+    // 1. Display predictions inline when there are no language server completions available.
+    //     "mode": "eager"
+    // 2. Display predictions inline only when holding a modifier key (alt by default).
+    //     "mode": "subtle"
+    "mode": "eager"
   },
   // Settings specific to journaling
   "journal": {

crates/editor/src/editor.rs

@@ -4959,7 +4959,7 @@ impl Editor {
                 });
 
         let preview_requires_modifier =
-            all_language_settings(file, cx).edit_predictions_mode() == EditPredictionsMode::Auto;
+            all_language_settings(file, cx).edit_predictions_mode() == EditPredictionsMode::Subtle;
 
         EditPredictionSettings::Enabled {
             show_in_menu,

crates/inline_completion_button/src/inline_completion_button.rs

@@ -592,8 +592,8 @@ impl InlineCompletionButton {
 
         if cx.has_flag::<feature_flags::PredictEditsNonEagerModeFeatureFlag>() {
             let is_eager_preview_enabled = match settings.edit_predictions_mode() {
-                language::EditPredictionsMode::Auto => false,
-                language::EditPredictionsMode::EagerPreview => true,
+                language::EditPredictionsMode::Subtle => false,
+                language::EditPredictionsMode::Eager => true,
             };
             menu = menu.separator().toggleable_entry(
                 "Eager Preview Mode",
@@ -608,8 +608,8 @@ impl InlineCompletionButton {
                             cx,
                             move |settings, _cx| {
                                 let new_mode = match is_eager_preview_enabled {
-                                    true => language::EditPredictionsMode::Auto,
-                                    false => language::EditPredictionsMode::EagerPreview,
+                                    true => language::EditPredictionsMode::Subtle,
+                                    false => language::EditPredictionsMode::Eager,
                                 };
 
                                 if let Some(edit_predictions) = settings.edit_predictions.as_mut() {

crates/language/src/language_settings.rs

@@ -244,10 +244,11 @@ pub struct EditPredictionSettings {
 pub enum EditPredictionsMode {
     /// If provider supports it, display inline when holding modifier key (e.g., alt).
     /// Otherwise, eager preview is used.
-    Auto,
+    Subtle,
     /// Display inline when there are no language server completions available.
     #[default]
-    EagerPreview,
+    #[serde(alias = "eager_preview")]
+    Eager,
 }
 
 #[derive(Clone, Debug, Default)]