From d858f5236f72aec6369dd3b0eec15acab987dc67 Mon Sep 17 00:00:00 2001 From: Kunall Banerjee Date: Thu, 26 Feb 2026 13:53:17 -0500 Subject: [PATCH] settings: Remove unused `file_finder.git_status` setting (#49889) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From the looks of it, this setting was never used by the File Finder. It also doesn’t make much sense to show git info in the File Finder. The Project Panel already exposes this information to the user. Closes #49709. | Before | After | |--------|--------| | image | image | Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Removed unused `file_finder.git_status` setting --- assets/settings/default.json | 2 -- .../settings_content/src/settings_content.rs | 4 ---- crates/settings_ui/src/page_data.rs | 20 +------------------ docs/src/visual-customization.md | 1 - 4 files changed, 1 insertion(+), 26 deletions(-) diff --git a/assets/settings/default.json b/assets/settings/default.json index f9f4fb417e4b0664170f9f6958966018bb48bc63..cb1e30bbee45ba06de8866fe3b8b6f0ab38b61da 100644 --- a/assets/settings/default.json +++ b/assets/settings/default.json @@ -1271,8 +1271,6 @@ // // Default: true "skip_focus_for_active_in_search": true, - // Whether to show the git status in the file finder. - "git_status": true, // Whether to use gitignored files when searching. // Only the file Zed had indexed will be used, not necessary all the gitignored files. // diff --git a/crates/settings_content/src/settings_content.rs b/crates/settings_content/src/settings_content.rs index 8c4845e05cbf16d0aacb089a5d16dcdb0ff6d7c7..f94c6a0b98d7fa23686dc1c89012e3b1fe476c70 100644 --- a/crates/settings_content/src/settings_content.rs +++ b/crates/settings_content/src/settings_content.rs @@ -716,10 +716,6 @@ pub struct FileFinderSettingsContent { /// /// Default: true pub skip_focus_for_active_in_search: Option, - /// Determines whether to show the git status in the file finder - /// - /// Default: true - pub git_status: Option, /// Whether to use gitignored files when searching. /// Only the file Zed had indexed will be used, not necessary all the gitignored files. /// diff --git a/crates/settings_ui/src/page_data.rs b/crates/settings_ui/src/page_data.rs index 5b3f5480148c30ef89bcae29b23986eac29808d9..afc84a9f9b91e32f3a110e19dc78db5634369458 100644 --- a/crates/settings_ui/src/page_data.rs +++ b/crates/settings_ui/src/page_data.rs @@ -3154,7 +3154,7 @@ fn search_and_files_page() -> SettingsPage { ] } - fn file_finder_section() -> [SettingsPageItem; 6] { + fn file_finder_section() -> [SettingsPageItem; 5] { [ SettingsPageItem::SectionHeader("File Finder"), // todo: null by default @@ -3242,24 +3242,6 @@ fn search_and_files_page() -> SettingsPage { metadata: None, files: USER, }), - SettingsPageItem::SettingItem(SettingItem { - title: "Git Status", - description: "Show the Git status in the file finder.", - field: Box::new(SettingField { - json_path: Some("file_finder.git_status"), - pick: |settings_content| { - settings_content.file_finder.as_ref()?.git_status.as_ref() - }, - write: |settings_content, value| { - settings_content - .file_finder - .get_or_insert_default() - .git_status = value; - }, - }), - metadata: None, - files: USER, - }), ] } diff --git a/docs/src/visual-customization.md b/docs/src/visual-customization.md index 7f84fe8b289295c2562b5eba21ec512948da3552..0e18c59fda21014a80ea8f362486711e204016e0 100644 --- a/docs/src/visual-customization.md +++ b/docs/src/visual-customization.md @@ -436,7 +436,6 @@ TBD: Centered layout related settings "file_finder": { "file_icons": true, // Show/hide file icons "modal_max_width": "small", // Horizontal size: small, medium, large, xlarge, full - "git_status": true, // Show the git status for each entry "include_ignored": null // gitignored files in results: true, false, null }, ```