Remove unused tasks-related config (#27707)

Kirill Bulatov created 9 months ago

Release Notes:

- N/A

Change summary

Cargo.lock                      |  2 --
assets/settings/default.json    |  5 -----
crates/tasks_ui/Cargo.toml      |  2 --
crates/tasks_ui/src/settings.rs | 25 -------------------------
crates/tasks_ui/src/tasks_ui.rs |  3 ---
5 files changed, 37 deletions(-)

Detailed changes

Cargo.lock

@@ -13797,10 +13797,8 @@ dependencies = [
  "menu",
  "picker",
  "project",
- "schemars",
  "serde",
  "serde_json",
- "settings",
  "task",
  "tree-sitter-rust",
  "tree-sitter-typescript",

assets/settings/default.json

@@ -1475,11 +1475,6 @@
   "dev": {
     // "theme": "Andromeda"
   },
-  // Task-related settings.
-  "task": {
-    // Whether to show task status indicator in the status bar. Default: true
-    "show_status_indicator": true
-  },
   // Whether to show full labels in line indicator or short ones
   //
   // Values:

crates/tasks_ui/Cargo.toml

@@ -23,9 +23,7 @@ menu.workspace = true
 picker.workspace = true
 project.workspace = true
 task.workspace = true
-schemars.workspace = true
 serde.workspace = true
-settings.workspace = true
 ui.workspace = true
 util.workspace = true
 workspace.workspace = true

crates/tasks_ui/src/settings.rs

@@ -1,25 +0,0 @@
-use schemars::JsonSchema;
-use serde::{Deserialize, Serialize};
-use settings::{Settings, SettingsSources};
-
-#[derive(Serialize, Deserialize, PartialEq, Default)]
-pub(crate) struct TaskSettings {
-    pub(crate) show_status_indicator: bool,
-}
-
-/// Task-related settings.
-#[derive(Serialize, Deserialize, PartialEq, Default, Clone, JsonSchema)]
-pub(crate) struct TaskSettingsContent {
-    /// Whether to show task status indicator in the status bar. Default: true
-    show_status_indicator: Option<bool>,
-}
-
-impl Settings for TaskSettings {
-    const KEY: Option<&'static str> = Some("task");
-
-    type FileContent = TaskSettingsContent;
-
-    fn load(sources: SettingsSources<Self::FileContent>, _: &mut gpui::App) -> gpui::Result<Self> {
-        sources.json_merge()
-    }
-}

crates/tasks_ui/src/tasks_ui.rs

@@ -1,7 +1,6 @@
 use std::collections::HashMap;
 use std::path::Path;
 
-use ::settings::Settings;
 use editor::Editor;
 use feature_flags::{Debugger, FeatureFlagViewExt};
 use gpui::{App, AppContext as _, Context, Entity, Task, Window};
@@ -12,12 +11,10 @@ use workspace::tasks::schedule_task;
 use workspace::{tasks::schedule_resolved_task, Start, Workspace};
 
 mod modal;
-mod settings;
 
 pub use modal::{Rerun, Spawn};
 
 pub fn init(cx: &mut App) {
-    settings::TaskSettings::register(cx);
     cx.observe_new(
         |workspace: &mut Workspace, window: Option<&mut Window>, cx: &mut Context<Workspace>| {
             workspace