From dace3ab152f1a530b83a4f1e3ebd3267fd7c9f80 Mon Sep 17 00:00:00 2001 From: Xiaobo Liu Date: Thu, 19 Feb 2026 17:00:55 +0800 Subject: [PATCH] project: Log errors when notifying JSON language server (#49480) Release Notes: - N/A --------- Signed-off-by: Xiaobo Liu Co-authored-by: Kirill Bulatov --- .../src/lsp_store/json_language_server_ext.rs | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/crates/project/src/lsp_store/json_language_server_ext.rs b/crates/project/src/lsp_store/json_language_server_ext.rs index 8d03dde032303210c9de7ec30b8144c0a3cb8c99..13c3aeb2b1ab2f4ab5f22a3cd065d4d0ff4bcb38 100644 --- a/crates/project/src/lsp_store/json_language_server_ext.rs +++ b/crates/project/src/lsp_store/json_language_server_ext.rs @@ -63,9 +63,17 @@ pub fn notify_schema_changed(lsp_store: Entity, uri: String, cx: &App) servers }); for server in servers { - zlog::trace!(LOGGER => "Notifying server {:?} of schema change for URI: {:?}", server.server_id(), &uri); - // TODO: handle errors - server.notify::(uri.clone()).ok(); + zlog::trace!(LOGGER => "Notifying server {NAME} (id {ID:?}) of schema change for URI: {uri:?}", + NAME = server.name(), + ID = server.server_id() + ); + if let Err(error) = server.notify::(uri.clone()) { + zlog::error!( + LOGGER => "Failed to notify server {NAME} (id {ID:?}) of schema change for URI {uri:?}: {error:#}", + NAME = server.name(), + ID = server.server_id(), + ); + } } }