Don't retain message payloads in span, just log the payload instead

Antonio Scandurra created 3 years ago

Change summary

crates/collab/src/rpc.rs | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)

Detailed changes

crates/collab/src/rpc.rs

@@ -207,9 +207,14 @@ impl Server {
                 let envelope = envelope.into_any().downcast::<TypedEnvelope<M>>().unwrap();
                 let span = info_span!(
                     "handle message",
-                    payload_type = envelope.payload_type_name(),
-                    payload = format!("{:?}", envelope.payload).as_str(),
+                    payload_type = envelope.payload_type_name()
                 );
+                span.in_scope(|| {
+                    tracing::info!(
+                        payload = format!("{:?}", envelope.payload).as_str(),
+                        "message payload"
+                    );
+                });
                 let future = (handler)(server, *envelope);
                 async move {
                     if let Err(error) = future.await {