title_bar: Render chevron if `show_user_picture` is disabled (#40474)

Lukas Wirth created 2 weeks ago

Closes https://github.com/zed-industries/zed/issues/40460

Release Notes:

- N/A *or* Added/Fixed/Improved ...

Change summary

crates/title_bar/src/title_bar.rs | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

Detailed changes

crates/title_bar/src/title_bar.rs

@@ -761,15 +761,10 @@ impl TitleBar {
                 .into()
             })
             .map(|this| {
-                if is_signed_in {
+                if is_signed_in && TitleBarSettings::get_global(cx).show_user_picture {
                     this.trigger_with_tooltip(
-                        ButtonLike::new("user-menu").children(
-                            TitleBarSettings::get_global(cx)
-                                .show_user_picture
-                                .then(|| user_avatar.clone())
-                                .flatten()
-                                .map(|avatar| Avatar::new(avatar)),
-                        ),
+                        ButtonLike::new("user-menu")
+                            .children(user_avatar.clone().map(|avatar| Avatar::new(avatar))),
                         Tooltip::text("Toggle User Menu"),
                     )
                 } else {