From dd3b65f7078e2903f5e5d2320fe70ffce50a38fc Mon Sep 17 00:00:00 2001 From: Ben Brandt Date: Wed, 8 Oct 2025 16:17:37 +0200 Subject: [PATCH] acp: Don't display failed terminal call on display only terminals (#39780) We don't get an ExitStatus from a remote terminal, so this check was failing. Ideally we move all of this to just needing an exit code, but we will have to revisit that later. Release Notes: - N/A --- crates/agent_ui/src/acp/thread_view.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/agent_ui/src/acp/thread_view.rs b/crates/agent_ui/src/acp/thread_view.rs index 7d8fdcb9368a1c75407eb920cba87838fd9e5d08..2f08abb600e178052699f2a9be6886830f23e797 100644 --- a/crates/agent_ui/src/acp/thread_view.rs +++ b/crates/agent_ui/src/acp/thread_view.rs @@ -2727,7 +2727,7 @@ impl AcpThreadView { let output_line_count = output.map(|output| output.content_line_count).unwrap_or(0); let command_failed = command_finished - && output.is_some_and(|o| o.exit_status.is_none_or(|status| !status.success())); + && output.is_some_and(|o| o.exit_status.is_some_and(|status| !status.success())); let time_elapsed = if let Some(output) = output { output.ended_at.duration_since(started_at)