Revert "Improve TS/TSX/JS syntax highlighting for parameters, types, and punctuation" (#44490)

Gaauwe Rombouts created 

Reverts zed-industries/zed#43437

Internally we noticed some regression related to removed query for
PascalCase identifiers. Reverting now to prevent this from going to
preview, still planning to land this with the necessary fixes later.

Change summary

crates/languages/src/javascript/highlights.scm | 39 -------
crates/languages/src/jsdoc/highlights.scm      |  1 
crates/languages/src/tsx/highlights.scm        | 93 -------------------
crates/languages/src/typescript/highlights.scm | 94 -------------------
4 files changed, 6 insertions(+), 221 deletions(-)

Detailed changes

crates/languages/src/javascript/highlights.scm 🔗 

@@ -47,45 +47,10 @@
   left: (identifier) @function
   right: [(function_expression) (arrow_function)])
 
-; Parameters
-
-(required_parameter
-  (identifier) @variable.parameter)
-
-(required_parameter
-  (_
-    ([
-      (identifier)
-      (shorthand_property_identifier_pattern)
-    ]) @variable.parameter))
-
-(optional_parameter
-  (identifier) @variable.parameter)
-
-(optional_parameter
-  (_
-    ([
-      (identifier)
-      (shorthand_property_identifier_pattern)
-    ]) @variable.parameter))
-
-(catch_clause
-  parameter: (identifier) @variable.parameter)
-
-(index_signature
-  name: (identifier) @variable.parameter)
-
-(arrow_function
-  parameter: (identifier) @variable.parameter)
-
 ; Special identifiers
-;
-(class_declaration
-  (type_identifier) @type.class)
-
-(extends_clause
-  value: (identifier) @type.class)
 
+((identifier) @type
+ (#match? @type "^[A-Z]"))
 (type_identifier) @type
 (predefined_type) @type.builtin

crates/languages/src/tsx/highlights.scm 🔗 

@@ -47,68 +47,13 @@
   left: (identifier) @function
   right: [(function_expression) (arrow_function)])
 
-; Parameters
-
-(required_parameter
-  (identifier) @variable.parameter)
-
-(required_parameter
-  (_
-    ([
-      (identifier)
-      (shorthand_property_identifier_pattern)
-    ]) @variable.parameter))
-
-(optional_parameter
-  (identifier) @variable.parameter)
-
-(optional_parameter
-  (_
-    ([
-      (identifier)
-      (shorthand_property_identifier_pattern)
-    ]) @variable.parameter))
-
-(catch_clause
-  parameter: (identifier) @variable.parameter)
-
-(index_signature
-  name: (identifier) @variable.parameter)
-
-(arrow_function
-  parameter: (identifier) @variable.parameter)
-
-(type_predicate
-  name: (identifier) @variable.parameter)
-
 ; Special identifiers
 
-(type_annotation) @type
+((identifier) @type
+ (#match? @type "^[A-Z]"))
 (type_identifier) @type
 (predefined_type) @type.builtin
 
-(type_alias_declaration
-  (type_identifier) @type)
-
-(type_alias_declaration
-  value: (_
-    (type_identifier) @type))
-
-(interface_declaration
-  (type_identifier) @type)
-
-(class_declaration
-  (type_identifier) @type.class)
-
-(extends_clause
-  value: (identifier) @type.class)
-
-(extends_type_clause
-  type: (type_identifier) @type)
-
-(implements_clause
-  (type_identifier) @type)
-
 ([
   (identifier)
   (shorthand_property_identifier)
@@ -286,42 +231,8 @@
   "<" @punctuation.bracket
   ">" @punctuation.bracket)
 
-(type_parameters
-  "<" @punctuation.bracket
-  ">" @punctuation.bracket)
-
 (decorator "@" @punctuation.special)
 
-(union_type
-  ("|") @punctuation.special)
-
-(intersection_type
-  ("&") @punctuation.special)
-
-(type_annotation
-  (":") @punctuation.special)
-
-(index_signature
-  (":") @punctuation.special)
-
-(type_predicate_annotation
-  (":") @punctuation.special)
-
-(public_field_definition
-  ("?") @punctuation.special)
-
-(property_signature
-  ("?") @punctuation.special)
-
-(method_signature
-  ("?") @punctuation.special)
-
-(optional_parameter
-  ([
-    "?"
-    ":"
-  ]) @punctuation.special)
-
 ; Keywords
 
 [ "abstract"

crates/languages/src/typescript/highlights.scm 🔗 

@@ -4,33 +4,11 @@
 
 ; Special identifiers
 
-(type_annotation) @type
-
+((identifier) @type
+ (#match? @type "^[A-Z]"))
 (type_identifier) @type
 (predefined_type) @type.builtin
 
-(type_alias_declaration
-  (type_identifier) @type)
-
-(type_alias_declaration
-  value: (_
-    (type_identifier) @type))
-
-(interface_declaration
-  (type_identifier) @type)
-
-(class_declaration
-  (type_identifier) @type.class)
-
-(extends_clause
-  value: (identifier) @type.class)
-
-(extends_type_clause
-  type: (type_identifier) @type)
-
-(implements_clause
-  (type_identifier) @type)
-
 ;; Enables ts-pretty-errors
 ;; The Lsp returns "snippets" of typescript, which are not valid typescript in totality,
 ;; but should still be highlighted
@@ -136,40 +114,6 @@
 
 (arrow_function) @function
 
-; Parameters
-
-(required_parameter
-  (identifier) @variable.parameter)
-
-(required_parameter
-  (_
-    ([
-      (identifier)
-      (shorthand_property_identifier_pattern)
-    ]) @variable.parameter))
-
-(optional_parameter
-  (identifier) @variable.parameter)
-
-(optional_parameter
-  (_
-    ([
-      (identifier)
-      (shorthand_property_identifier_pattern)
-    ]) @variable.parameter))
-
-(catch_clause
-  parameter: (identifier) @variable.parameter)
-
-(index_signature
-  name: (identifier) @variable.parameter)
-
-(arrow_function
-  parameter: (identifier) @variable.parameter)
-
-(type_predicate
-  name: (identifier) @variable.parameter)
-
 ; Literals
 
 (this) @variable.special
@@ -300,42 +244,8 @@
   "<" @punctuation.bracket
   ">" @punctuation.bracket)
 
-(type_parameters
-  "<" @punctuation.bracket
-  ">" @punctuation.bracket)
-
 (decorator "@" @punctuation.special)
 
-(union_type
-  ("|") @punctuation.special)
-
-(intersection_type
-  ("&") @punctuation.special)
-
-(type_annotation
-  (":") @punctuation.special)
-
-(index_signature
-  (":") @punctuation.special)
-
-(type_predicate_annotation
-  (":") @punctuation.special)
-
-(public_field_definition
-  ("?") @punctuation.special)
-
-(property_signature
-  ("?") @punctuation.special)
-
-(method_signature
-  ("?") @punctuation.special)
-
-(optional_parameter
-  ([
-    "?"
-    ":"
-  ]) @punctuation.special)
-
 ; Keywords
 
 [