Fix completion menu jumping (#22780)

Conrad Irwin and Thorsten created 1 year ago

Co-Authored-By: Thorsten <[e-mail]>

Release Notes:

- Fix selected suggestion updating too many times when Zeta triggers

Co-authored-by: Thorsten <[e-mail]>

Change summary

crates/editor/src/code_context_menus.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Detailed changes

crates/editor/src/code_context_menus.rs

@@ -334,6 +334,9 @@ impl CompletionsMenu {
                 entries
             }
             _ => {
+                if self.selected_item != 0 {
+                    self.selected_item += 1;
+                }
                 let mut entries = Vec::with_capacity(self.entries.len() + 1);
                 entries.push(hint);
                 entries.extend_from_slice(&self.entries);
@@ -341,9 +344,6 @@ impl CompletionsMenu {
             }
         }
         .into();
-        if self.selected_item != 0 && self.selected_item + 1 < self.entries.len() {
-            self.selected_item += 1;
-        }
     }
 
     pub fn resolve_visible_completions(