From e24538dc626e00be503d1bb8649f17fe4d12e4b4 Mon Sep 17 00:00:00 2001 From: Om Chillure Date: Thu, 12 Feb 2026 17:51:54 +0530 Subject: [PATCH] Fix assistant commands visibility when agent is disabled (#48951) ## Changes - Hide `assistant` namespace when `agent.enabled = false` - Added test coverage for assistant command visibility ## Testing - Verified manually that commands are hidden/shown dynamically - Added test assertions in [test_agent_command_palette_visibility](cci:1://file:///media/omchillure/Projects/zed-oss/zed/crates/agent_ui/src/agent_ui.rs:525:4-657:5) - Test passes: `cargo test -p agent_ui test_agent_command_palette_visibility` ## Video : [Screencast from 2026-02-11 21-01-30.webm](https://github.com/user-attachments/assets/bbdb3e44-4ba9-4def-ad05-74e412bc5dba) ## Release Notes: - Fixed assistant commands (Copy Code, Insert Into Editor, etc.) remaining visible in the command palette when the agent is disabled in settings. --- crates/agent_ui/src/agent_ui.rs | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/crates/agent_ui/src/agent_ui.rs b/crates/agent_ui/src/agent_ui.rs index d7f003e95b7e3c286b45e3e5272463a32ac1a9b2..8cd512c0e4358ea46e5de9145c014b66d9ebf7ce 100644 --- a/crates/agent_ui/src/agent_ui.rs +++ b/crates/agent_ui/src/agent_ui.rs @@ -377,13 +377,13 @@ fn update_command_palette_filter(cx: &mut App) { if agent_enabled { filter.show_namespace("agent"); filter.show_namespace("agents"); + filter.show_namespace("assistant"); } else { filter.hide_namespace("agent"); filter.hide_namespace("agents"); + filter.hide_namespace("assistant"); } - filter.show_namespace("assistant"); - match edit_prediction_provider { EditPredictionProvider::None => { filter.hide_namespace("edit_prediction"); @@ -588,6 +588,10 @@ mod tests { !filter.is_hidden(&NewThread), "NewThread should be visible by default" ); + assert!( + !filter.is_hidden(&text_thread_editor::CopyCode), + "CopyCode should be visible when agent is enabled" + ); }); // Disable agent @@ -607,6 +611,10 @@ mod tests { filter.is_hidden(&NewThread), "NewThread should be hidden when agent is disabled" ); + assert!( + filter.is_hidden(&text_thread_editor::CopyCode), + "CopyCode should be hidden when agent is disabled" + ); }); // Test EditPredictionProvider