From e27590432f438c960cc54e086c5a4f801de9b223 Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Mon, 1 Dec 2025 19:53:36 -0700 Subject: [PATCH] Actually show settings errors on app load (#43268) They were previously hidden by the global settings file succeeding to parse :face-palm: Release Notes: - N/A --- crates/zed/src/zed.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/crates/zed/src/zed.rs b/crates/zed/src/zed.rs index 41f5d970dd8a81136df522f38f9381bf208bd608..49a43eae47fe36c9cd93f3ce6371cf39c5f5e514 100644 --- a/crates/zed/src/zed.rs +++ b/crates/zed/src/zed.rs @@ -1394,8 +1394,7 @@ fn notify_settings_errors(result: settings::SettingsParseResult, is_user: bool, settings::ParseStatus::Failed { error } => Some(anyhow::format_err!(error)), settings::ParseStatus::Success => None, }; - struct SettingsParseErrorNotification; - let id = NotificationId::unique::(); + let id = NotificationId::Named(format!("failed-to-parse-settings-{is_user}").into()); let showed_parse_error = match error { Some(error) => { @@ -1427,7 +1426,7 @@ fn notify_settings_errors(result: settings::SettingsParseResult, is_user: bool, false } }; - let id = NotificationId::Named("failed-to-migrate-settings".into()); + let id = NotificationId::Named(format!("failed-to-migrate-settings-{is_user}").into()); match result.migration_status { settings::MigrationStatus::Succeeded | settings::MigrationStatus::NotNeeded => {