misc

Junkui Zhang created 4 months ago

Change summary

crates/gpui/build.rs                                 | 2 +-
crates/gpui/src/platform/windows/directx_renderer.rs | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)

Detailed changes

crates/gpui/build.rs

@@ -322,7 +322,7 @@ mod windows {
         }
 
         // Try to find in PATH
-        // NOTE: This has to be `where.exe` on Windows, not `which`
+        // NOTE: This has to be `where.exe` on Windows, not `where`, it must be ended with `.exe`
         if let Ok(output) = std::process::Command::new("where.exe")
             .arg("fxc.exe")
             .output()

crates/gpui/src/platform/windows/directx_renderer.rs

@@ -564,8 +564,8 @@ impl DirectXRenderer {
         let driver_version = match desc.VendorId {
             0x10DE => nvidia::get_driver_version(),
             0x1002 => amd::get_driver_version(),
-            0x8086 => intel::get_driver_version(&self.devices.adapter),
-            id => Err(anyhow::anyhow!("Unknown vendor detected (ID: {:#X}).", id)),
+            // For Intel and other vendors, we use the DXGI API to get the driver version.
+            _ => dxgi::get_driver_version(&self.devices.adapter),
         }
         .context("Failed to get gpu driver info")
         .log_err()
@@ -1710,7 +1710,7 @@ mod amd {
     }
 }
 
-mod intel {
+mod dxgi {
     use windows::{
         Win32::Graphics::Dxgi::{IDXGIAdapter1, IDXGIDevice},
         core::Interface,