Fix Div::active not working

Antonio Scandurra created 2 years ago

Somehow a condition got inverted and caused the bug.

Change summary

crates/gpui2/src/elements/div.rs       | 2 +-
crates/storybook2/src/stories/focus.rs | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)

Detailed changes

crates/gpui2/src/elements/div.rs

@@ -984,7 +984,7 @@ impl Interactivity {
         }
 
         let active_state = element_state.clicked_state.clone();
-        if !active_state.borrow().is_clicked() {
+        if active_state.borrow().is_clicked() {
             cx.on_mouse_event(move |_: &MouseUpEvent, phase, cx| {
                 if phase == DispatchPhase::Capture {
                     *active_state.borrow_mut() = ElementClickedState::default();

crates/storybook2/src/stories/focus.rs

@@ -66,9 +66,11 @@ impl Render for FocusStory {
         let color_4 = theme.status().conflict;
         let color_5 = theme.status().ignored;
         let color_6 = theme.status().renamed;
+        let color_7 = theme.status().hint;
 
         div()
             .id("parent")
+            .active(|style| style.bg(color_7))
             .track_focus(&self.parent_focus)
             .key_context("parent")
             .on_action(cx.listener(|_, _action: &ActionA, _cx| {