From e59d7eb618549f1a032d40e6e3b7ab8eb5eae735 Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Wed, 24 Jan 2024 13:25:22 -0700 Subject: [PATCH] Fix crash in feedback modal (#6431) After the general release we saw a number of crashes due to a SEGFAULT inside the System::new() method apparently relating to refreshing the user list. As we do not need the user list, and the similar code in the telemtry create is not crashing, do less work for now. Release Notes: - Fixed a crash when opening the feedback modal --- crates/feedback/src/system_specs.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/feedback/src/system_specs.rs b/crates/feedback/src/system_specs.rs index cc51f93aba14989409b3c01af322669eb8b12dc1..099e7460b4a374c6f487e2ebda61c9ac66e3a22e 100644 --- a/crates/feedback/src/system_specs.rs +++ b/crates/feedback/src/system_specs.rs @@ -3,7 +3,7 @@ use gpui::AppContext; use human_bytes::human_bytes; use serde::Serialize; use std::{env, fmt::Display}; -use sysinfo::{System, SystemExt}; +use sysinfo::{RefreshKind, System, SystemExt}; use util::channel::ReleaseChannel; #[derive(Clone, Debug, Serialize)] @@ -23,7 +23,7 @@ impl SystemSpecs { .map(|v| v.to_string()); let release_channel = cx.global::().display_name(); let os_name = cx.app_metadata().os_name; - let system = System::new_all(); + let system = System::new_with_specifics(RefreshKind::new().with_memory()); let memory = system.total_memory(); let architecture = env::consts::ARCH; let os_version = cx