Fix Clippy warnings in `fuzzy` crate (#8701)

Marshall Bowers created 2 years ago

This PR fixes a number of Clippy warnings in the `fuzzy` crate.

Release Notes:

- N/A

Change summary

crates/fuzzy/src/char_bag.rs | 4 ++--
crates/fuzzy/src/paths.rs    | 2 +-
crates/fuzzy/src/strings.rs  | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)

Detailed changes

crates/fuzzy/src/char_bag.rs

@@ -10,14 +10,14 @@ impl CharBag {
 
     fn insert(&mut self, c: char) {
         let c = c.to_ascii_lowercase();
-        if ('a'..='z').contains(&c) {
+        if c.is_ascii_lowercase() {
             let mut count = self.0;
             let idx = c as u8 - b'a';
             count >>= idx * 2;
             count = ((count << 1) | 1) & 3;
             count <<= idx * 2;
             self.0 |= count;
-        } else if ('0'..='9').contains(&c) {
+        } else if c.is_ascii_digit() {
             let idx = c as u8 - b'0';
             self.0 |= 1 << (idx + 52);
         } else if c == '-' {

crates/fuzzy/src/paths.rs

@@ -200,7 +200,7 @@ pub async fn match_path_sets<'a, Set: PathMatchCandidateSet<'a>>(
                                         usize::MAX,
                                         |relative_to| {
                                             distance_between_paths(
-                                                candidate.path.as_ref(),
+                                                candidate.path,
                                                 relative_to.as_ref(),
                                             )
                                         },

crates/fuzzy/src/strings.rs

@@ -57,10 +57,10 @@ pub struct StringMatch {
 }
 
 impl StringMatch {
-    pub fn ranges<'a>(&'a self) -> impl 'a + Iterator<Item = Range<usize>> {
+    pub fn ranges(&self) -> impl '_ + Iterator<Item = Range<usize>> {
         let mut positions = self.positions.iter().peekable();
         iter::from_fn(move || {
-            while let Some(start) = positions.next().copied() {
+            if let Some(start) = positions.next().copied() {
                 let mut end = start + self.char_len_at_index(start);
                 while let Some(next_start) = positions.peek() {
                     if end == **next_start {