Log instead of showing an alert when exiting due to no GPU

Max Brunsfeld created 3 years ago

Showing the alert resulted in a panic because tasks
dispatched to the app's main GCD queue continue
to run even while the alert is displayed.

Change summary

crates/gpui/src/platform/mac/window.rs | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)

Detailed changes

crates/gpui/src/platform/mac/window.rs

@@ -13,8 +13,8 @@ use crate::{
 use block::ConcreteBlock;
 use cocoa::{
     appkit::{
-        CGPoint, NSApplication, NSBackingStoreBuffered, NSModalResponse, NSScreen, NSView,
-        NSViewHeightSizable, NSViewWidthSizable, NSWindow, NSWindowButton, NSWindowStyleMask,
+        CGPoint, NSApplication, NSBackingStoreBuffered, NSScreen, NSView, NSViewHeightSizable,
+        NSViewWidthSizable, NSWindow, NSWindowButton, NSWindowStyleMask,
     },
     base::{id, nil},
     foundation::{
@@ -327,14 +327,10 @@ impl Window {
                 native_window.setFrame_display_(screen.visibleFrame(), YES);
             }
 
-            let device = if let Some(device) = metal::Device::system_default() {
+            let device: metal::Device = if let Some(device) = metal::Device::system_default() {
                 device
             } else {
-                let alert: id = msg_send![class!(NSAlert), alloc];
-                let _: () = msg_send![alert, init];
-                let _: () = msg_send![alert, setAlertStyle: 2];
-                let _: () = msg_send![alert, setMessageText: ns_string("Unable to access a compatible graphics device")];
-                let _: NSModalResponse = msg_send![alert, runModal];
+                log::error!("unable to access a compatible graphics device");
                 std::process::exit(1);
             };