Add panic if version is 0.91

Mikayla Maki created 2 years ago

Change summary

crates/workspace/src/notifications.rs | 11 +++++++----
crates/workspace/src/pane.rs          |  1 -
crates/workspace/src/workspace.rs     | 14 ++------------
3 files changed, 9 insertions(+), 17 deletions(-)

Detailed changes

crates/workspace/src/notifications.rs

@@ -163,9 +163,10 @@ pub mod simple_message_notification {
     use gpui::{
         actions,
         elements::{Flex, MouseEventHandler, Padding, ParentElement, Svg, Text},
+        fonts::TextStyle,
         impl_actions,
         platform::{CursorStyle, MouseButton},
-        AnyElement, AppContext, Element, Entity, View, ViewContext, fonts::TextStyle,
+        AnyElement, AppContext, Element, Entity, View, ViewContext,
     };
     use menu::Cancel;
     use serde::Deserialize;
@@ -224,8 +225,9 @@ pub mod simple_message_notification {
             }
         }
 
-        pub fn new_element(message: fn(TextStyle, &AppContext) -> AnyElement<MessageNotification>) -> MessageNotification
-        {
+        pub fn new_element(
+            message: fn(TextStyle, &AppContext) -> AnyElement<MessageNotification>,
+        ) -> MessageNotification {
             Self {
                 message: NotificationMessage::Element(message),
                 on_click: None,
@@ -279,7 +281,8 @@ pub mod simple_message_notification {
                 .with_child(
                     Flex::row()
                         .with_child(
-                            message.contained()
+                            message
+                                .contained()
                                 .with_style(theme.message.container)
                                 .aligned()
                                 .top()

crates/workspace/src/pane.rs

@@ -541,7 +541,6 @@ impl Pane {
         cx.spawn(|_, mut cx| async move { notify_of_new_dock(&workspace_handle, &mut cx) })
             .detach();
 
-
         if self.zoomed {
             cx.emit(Event::ZoomOut);
         } else if !self.items.is_empty() {

crates/workspace/src/workspace.rs

@@ -3198,13 +3198,8 @@ fn notify_of_new_dock(workspace: &WeakViewHandle<Workspace>, cx: &mut AsyncAppCo
     if workspace
         .read_with(cx, |workspace, cx| {
             let version = cx.global::<ZedVersion>().0;
-            if !version.contains("0.88")
-                && !version.contains("0.89")
-                && !version.contains("0.90")
-                && !version.contains("0.91")
-                && !version.contains("0.92")
-            {
-                return true;
+            if version.contains("0.91") {
+                panic!("Please remove the dock key binding change notification");
             }
             workspace.has_shown_notification_once::<MessageNotification>(MESSAGE_ID, cx)
         })
@@ -3251,8 +3246,6 @@ fn notify_of_new_dock(workspace: &WeakViewHandle<Workspace>, cx: &mut AsyncAppCo
     workspace
         .update(cx, |workspace, cx| {
             workspace.show_notification_once(2, cx, |cx| {
-
-
                 cx.add_view(|_| {
                     MessageNotification::new_element(|text, _| {
                         Text::new(
@@ -3274,9 +3267,6 @@ fn notify_of_new_dock(workspace: &WeakViewHandle<Workspace>, cx: &mut AsyncAppCo
                         })
                         .into_any()
                     })
-                    // MessageNotification::new_(
-                    //     "Looking for the dock? Try 'ctrl-`'!\n'shift-escape' now zooms your pane",
-                    // )
                     .with_click_message("Read more about the new panel system")
                     .on_click(|cx| cx.platform().open_url(NEW_PANEL_BLOG_POST))
                 })