Replace DeterministicExecutor::reset with forbid_parking

Nathan Sobo and Max Brunsfeld created

There's really no point calling reset if we plan on parking afterwards.

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Change summary

gpui/src/executor.rs | 15 +++------------
server/src/tests.rs  |  2 --
2 files changed, 3 insertions(+), 14 deletions(-)

Detailed changes

gpui/src/executor.rs 🔗

@@ -328,23 +328,14 @@ impl Foreground {
         }
     }
 
-    pub fn reset(&self) {
-        match self {
-            Self::Platform { .. } => panic!("can't call this method on a platform executor"),
-            Self::Test(_) => panic!("can't call this method on a test executor"),
-            Self::Deterministic(executor) => {
-                let state = &mut *executor.state.lock();
-                state.rng = StdRng::seed_from_u64(state.seed);
-            }
-        }
-    }
-
     pub fn forbid_parking(&self) {
         match self {
             Self::Platform { .. } => panic!("can't call this method on a platform executor"),
             Self::Test(_) => panic!("can't call this method on a test executor"),
             Self::Deterministic(executor) => {
-                executor.state.lock().forbid_parking = true;
+                let mut state = executor.state.lock();
+                state.forbid_parking = true;
+                state.rng = StdRng::seed_from_u64(state.seed);
             }
         }
     }

server/src/tests.rs 🔗

@@ -523,8 +523,6 @@ impl TestServer {
             .await
             .unwrap();
 
-        // Reset the executor because running SQL queries has a non-deterministic impact on it.
-        cx.foreground().reset();
         client
     }