From ee557fb7eafd8078831ce7f32cbf5239c4e6239d Mon Sep 17 00:00:00 2001
From: Mikayla Maki <mikayla@zed.dev>
Date: Mon, 6 Oct 2025 00:27:54 -0700
Subject: [PATCH] Add window close keybindings for Settings UI (#39578)

Closes #ISSUE

Release Notes:

- N/A
---
 assets/keymaps/default-linux.json   | 10 +++++++++-
 assets/keymaps/default-macos.json   |  7 +++++++
 assets/keymaps/default-windows.json | 10 +++++++++-
 3 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/assets/keymaps/default-linux.json b/assets/keymaps/default-linux.json
index f498bc54dfdc3ba4ba69a0141dc290f0c92382ec..eb625eaba1ad39d9268f2b5577c62ac3d35fb4a3 100644
--- a/assets/keymaps/default-linux.json
+++ b/assets/keymaps/default-linux.json
@@ -369,7 +369,15 @@
     "bindings": {
       "new": "rules_library::NewRule",
       "ctrl-n": "rules_library::NewRule",
-      "ctrl-shift-s": "rules_library::ToggleDefaultRule"
+      "ctrl-shift-s": "rules_library::ToggleDefaultRule",
+      "ctrl-w": "workspace::CloseWindow"
+    }
+  },
+  {
+    "context": "SettingsWindow",
+    "use_key_equivalents": true,
+    "bindings": {
+      "ctrl-w": "workspace::CloseWindow"
     }
   },
   {
diff --git a/assets/keymaps/default-macos.json b/assets/keymaps/default-macos.json
index f236c0a579ead90cb8f46d30f32290f8ed3d1988..3afa795244abc6639e4e1800d13ee02d64ff5177 100644
--- a/assets/keymaps/default-macos.json
+++ b/assets/keymaps/default-macos.json
@@ -430,6 +430,13 @@
       "cmd-w": "workspace::CloseWindow"
     }
   },
+  {
+    "context": "SettingsWindow",
+    "use_key_equivalents": true,
+    "bindings": {
+      "cmd-w": "workspace::CloseWindow"
+    }
+  },
   {
     "context": "BufferSearchBar",
     "use_key_equivalents": true,
diff --git a/assets/keymaps/default-windows.json b/assets/keymaps/default-windows.json
index 404542e12acf14d3f98579f02c20f60da31c7ef5..14a3ff6fcd6cd0ca196d2aae98bb9fa80ec211d7 100644
--- a/assets/keymaps/default-windows.json
+++ b/assets/keymaps/default-windows.json
@@ -378,7 +378,15 @@
     "use_key_equivalents": true,
     "bindings": {
       "ctrl-n": "rules_library::NewRule",
-      "ctrl-shift-s": "rules_library::ToggleDefaultRule"
+      "ctrl-shift-s": "rules_library::ToggleDefaultRule",
+      "ctrl-w": "workspace::CloseWindow"
+    }
+  },
+  {
+    "context": "SettingsWindow",
+    "use_key_equivalents": true,
+    "bindings": {
+      "ctrl-w": "workspace::CloseWindow"
     }
   },
   {