From ef9f28926c05764bf5da000e0566851310ebcdea Mon Sep 17 00:00:00 2001
From: David Kleingeld <davidsk@zed.dev>
Date: Wed, 17 Sep 2025 18:28:25 +0200
Subject: [PATCH] warn when denoise is enabled on debug

---
 Cargo.toml                         |  2 +-
 crates/audio/src/audio_settings.rs | 13 ++++++++++---
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index f31310690932767d27cc7daacc9cdd2059632870..f362a380af930823084072dc53260d8e2be0d749 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -780,8 +780,8 @@ codegen-units = 16
 codegen-units = 16
 
 [profile.dev.package]
+# Without optimizations we get audio artifacts (crackling)
 audio = { opt-level = 3 }
-denoise = { opt-level = 3 }
 taffy = { opt-level = 3 }
 cranelift-codegen = { opt-level = 3 }
 cranelift-codegen-meta = { opt-level = 3 }
diff --git a/crates/audio/src/audio_settings.rs b/crates/audio/src/audio_settings.rs
index 110d4b8cf6a49082b369166545c547e0f6585b11..8ee81a0061f648292cf871b28909f1f0f96e30bb 100644
--- a/crates/audio/src/audio_settings.rs
+++ b/crates/audio/src/audio_settings.rs
@@ -140,9 +140,16 @@ impl LiveSettings {
                 AudioSettings::get_global(cx).auto_speaker_volume,
                 Ordering::Relaxed,
             );
-            LIVE_SETTINGS
-                .denoise
-                .store(AudioSettings::get_global(cx).denoise, Ordering::Relaxed);
+
+            let denoise_enabled = AudioSettings::get_global(cx).denoise;
+            #[cfg(debug_assertions)]
+            if denoise_enabled {
+                log::warn!("Denoise does not work on debug builds, not enabling")
+            } else {
+                LIVE_SETTINGS
+                    .denoise
+                    .store(denoise_enabled, Ordering::Relaxed);
+            }
         })
         .detach();