Update top-ranking issues script (#42911)

Joseph T. Lyons created 1 month ago

- Added Windows category
- Removed unused import
- Fixed a type error reported by `ty`

Release Notes:

- N/A

Change summary

script/update_top_ranking_issues/main.py | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

Detailed changes

script/update_top_ranking_issues/main.py

@@ -1,5 +1,4 @@
 import os
-from collections import defaultdict
 from datetime import datetime, timedelta
 from typing import Optional
 
@@ -106,7 +105,7 @@ def get_label_to_issue_data(
     repository: Repository,
     start_date: datetime | None = None,
 ) -> dict[str, list[IssueData]]:
-    common_filters = [
+    common_queries = [
         f"repo:{repository.full_name}",
         "is:open",
         "is:issue",
@@ -119,9 +118,9 @@ def get_label_to_issue_data(
     )
 
     if date_query:
-        common_filters.append(date_query)
+        common_queries.append(date_query)
 
-    common_filter_string = " ".join(common_filters)
+    common_query = " ".join(common_queries)
 
     # Because PyGithub doesn't seem to support logical operators `AND` and `OR`
     # that GitHub issue queries can use, we use lists as values, rather than
@@ -135,16 +134,17 @@ def get_label_to_issue_data(
         "crash": ["label:crash", "type:Crash"],
         "feature": ["label:feature", "type:Feature"],
         "meta": ["type:Meta"],
+        "windows": ["label:windows"],
         "unlabeled": ["no:label no:type"],
     }
 
     label_to_issue_data: dict[str, list[IssueData]] = {}
 
-    for section, section_queries in section_queries.items():
+    for section, queries in section_queries.items():
         unique_issues = set()
 
-        for section_query in section_queries:
-            query: str = f"{common_filter_string} {section_query}"
+        for query in queries:
+            query: str = f"{common_query} {query}"
             issues = github.search_issues(query)
 
             for issue in issues: