From f1786b3b5f3fda5bad0d74cd008013f73b6b5f92 Mon Sep 17 00:00:00 2001 From: Jakub Konka Date: Tue, 14 Oct 2025 21:32:07 +0200 Subject: [PATCH] terminal: Simplify task_summary processing (#40201) Release Notes: - N/A --- crates/terminal/src/terminal.rs | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/crates/terminal/src/terminal.rs b/crates/terminal/src/terminal.rs index a434586fc339da56b85f0f5448d27d8a3b46e4e9..960812da00060a987fbaafe6f248a0d582d60e4f 100644 --- a/crates/terminal/src/terminal.rs +++ b/crates/terminal/src/terminal.rs @@ -2187,21 +2187,13 @@ fn task_summary(task: &TaskState, error_code: Option) -> (bool, String, Str .full_label .replace("\r\n", "\r") .replace('\n', "\r"); - let (success, task_line) = match error_code { - Some(0) => ( - true, - format!("{TASK_DELIMITER}Task `{escaped_full_label}` finished successfully"), - ), - Some(error_code) => ( - false, - format!( - "{TASK_DELIMITER}Task `{escaped_full_label}` finished with non-zero error code: {error_code}" - ), - ), - None => ( - false, - format!("{TASK_DELIMITER}Task `{escaped_full_label}` finished"), + let success = error_code == Some(0); + let task_line = match error_code { + Some(0) => format!("{TASK_DELIMITER}Task `{escaped_full_label}` finished successfully"), + Some(error_code) => format!( + "{TASK_DELIMITER}Task `{escaped_full_label}` finished with non-zero error code: {error_code}" ), + None => format!("{TASK_DELIMITER}Task `{escaped_full_label}` finished"), }; let escaped_command_label = task .spawned_task