Remove `collaborators_per_project` from `Metrics`

Antonio Scandurra and Nathan Sobo created 3 years ago

Co-Authored-By: Nathan Sobo <[e-mail]>

Change summary

crates/collab/src/rpc.rs       |  7 +++----
crates/collab/src/rpc/store.rs | 11 +----------
2 files changed, 4 insertions(+), 14 deletions(-)

Detailed changes

crates/collab/src/rpc.rs

@@ -1097,10 +1097,9 @@ impl<'a> Drop for StoreWriteGuard<'a> {
 
         let metrics = self.metrics();
         tracing::info!(
-            connections = metrics.connections as f32,
-            registered_projects = metrics.registered_projects as f32,
-            shared_projects = metrics.shared_projects as f32,
-            collaborators_per_project = metrics.collaborators_per_project,
+            connections = metrics.connections,
+            registered_projects = metrics.registered_projects,
+            shared_projects = metrics.shared_projects,
             "metrics"
         );
     }

crates/collab/src/rpc/store.rs

@@ -86,7 +86,6 @@ pub struct Metrics {
     pub connections: usize,
     pub registered_projects: usize,
     pub shared_projects: usize,
-    pub collaborators_per_project: f32,
 }
 
 impl Store {
@@ -94,25 +93,17 @@ impl Store {
         let connections = self.connections.len();
         let mut registered_projects = 0;
         let mut shared_projects = 0;
-        let mut collaborators = 0;
         for project in self.projects.values() {
             registered_projects += 1;
-            if let Some(share) = project.share.as_ref() {
+            if project.share.is_some() {
                 shared_projects += 1;
-                collaborators += share.active_replica_ids.len();
             }
         }
-        let collaborators_per_project = if shared_projects == 0 || collaborators == 0 {
-            0.
-        } else {
-            collaborators as f32 / shared_projects as f32
-        };
 
         Metrics {
             connections,
             registered_projects,
             shared_projects,
-            collaborators_per_project,
         }
     }