ci: Fix 'Run Tests' not always running (#26685)

Peter Tripp created 9 months ago

Follow up to:
- https://github.com/zed-industries/zed/pull/26551

We need the "Tests Pass" step to run `if: always()`. 
Turns out when it's 'skipped', it counts as 'passing' with respect to
required status checks.


Release Notes:

- N/A

Change summary

.github/workflows/ci.yml | 36 +++++++++++++++++++++---------------
1 file changed, 21 insertions(+), 15 deletions(-)

Detailed changes

.github/workflows/ci.yml

@@ -432,22 +432,28 @@ jobs:
       - macos_tests
       - windows_clippy
       - windows_tests
-    if: |
-      always() && (
-        needs.style.result == 'success'
-        && (
-          needs.job_spec.outputs.run_tests == 'false'
-          || (needs.macos_tests.result == 'success'
-              && needs.linux_tests.result == 'success'
-              && needs.windows_tests.result == 'success'
-              && needs.windows_clippy.result == 'success'
-              && needs.build_remote_server.result == 'success'
-              && needs.migration_checks.result == 'success')
-        )
-      )
+    if: always()
     steps:
-      - name: All tests passed
-        run: echo "All tests passed successfully!"
+      - name: Check all tests passed
+        run: |
+          # Check dependent jobs...
+          RET_CODE=0
+          # Always check style
+          [[ "${{ needs.style.result }}" != 'success' ]] && { RET_CODE=1; echo "style tests failed"; }
+
+          # Only check test jobs if they were supposed to run
+          if [[ "${{ needs.job_spec.outputs.run_tests }}" == "true" ]]; then
+            [[ "${{ needs.macos_tests.result }}"          != 'success' ]] && { RET_CODE=1; echo "macOS tests failed"; }
+            [[ "${{ needs.linux_tests.result }}"          != 'success' ]] && { RET_CODE=1; echo "Linux tests failed"; }
+            [[ "${{ needs.windows_tests.result }}"        != 'success' ]] && { RET_CODE=1; echo "Windows tests failed"; }
+            [[ "${{ needs.windows_clippy.result }}"       != 'success' ]] && { RET_CODE=1; echo "Windows clippy failed"; }
+            [[ "${{ needs.migration_checks.result }}"     != 'success' ]] && { RET_CODE=1; echo "Migration checks failed"; }
+            [[ "${{ needs.build_remote_server.result }}"  != 'success' ]] && { RET_CODE=1; echo "Remote server build failed"; }
+          fi
+          if [[ "$RET_CODE" -eq 0 ]]; then
+            echo "All tests passed successfully!"
+          fi
+          exit $RET_CODE
 
   bundle-mac:
     timeout-minutes: 120