From f88278111ee8d849b8f0adc89d7fbcbdbccd93a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=BC=A0=E5=B0=8F=E7=99=BD?= <364772080@qq.com> Date: Sun, 28 Jul 2024 01:05:48 +0800 Subject: [PATCH] Remove `TODO` in `JsonLspAdapter` (#15338) As the post-install issue is fixed via #15331 , we can remove this `TODO` now. I have tested on win11, it works fine. Release Notes: - N/A --- crates/languages/src/json.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crates/languages/src/json.rs b/crates/languages/src/json.rs index cec63874af65823be1d65d786aa9ab59c4eca2f5..f430a377b32902f4f1ba86569164c540b910a75c 100644 --- a/crates/languages/src/json.rs +++ b/crates/languages/src/json.rs @@ -166,11 +166,9 @@ impl LspAdapter for JsonLspAdapter { .await; if should_install_language_server { - // TODO: the postinstall fails on Windows self.node .npm_install_packages(&container_dir, &[(package_name, latest_version.as_str())]) - .await - .log_err(); + .await?; } Ok(LanguageServerBinary {