From f8979f1ed7f02db23802ac17a3cf2df9d0ed2506 Mon Sep 17 00:00:00 2001 From: Kirill Bulatov Date: Tue, 4 Nov 2025 00:42:26 +0200 Subject: [PATCH] Do not pull diagnostics when those are disabled (#41865) Based on [hang.log](https://github.com/user-attachments/files/23319081/hang.log) Release Notes: - N/A --- crates/editor/src/editor.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index b120f672994bfb1e107de698dbc6898f6cbd980c..b37c5474f87449d29f4239f72487d471b14a50bd 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -17785,6 +17785,7 @@ impl Editor { .unwrap_or(self.diagnostics_max_severity); if !self.inline_diagnostics_enabled() + || !self.diagnostics_enabled() || !self.show_inline_diagnostics || max_severity == DiagnosticSeverity::Off { @@ -17863,7 +17864,7 @@ impl Editor { window: &Window, cx: &mut Context, ) -> Option<()> { - if self.ignore_lsp_data() { + if self.ignore_lsp_data() || !self.diagnostics_enabled() { return None; } let pull_diagnostics_settings = ProjectSettings::get_global(cx)