From f92d44ed70ba74fd85e94d614b3aa13b63c4589f Mon Sep 17 00:00:00 2001 From: "Joseph T. Lyons" Date: Fri, 6 Oct 2023 14:20:06 -0400 Subject: [PATCH] Use display name for release channel in panic events (#3101) This was a mistake from long ago - something I've been meaning to fix for a long time. All other events use `display_name()`, but panic events, which leads to mistakes when filtering out `Zed Dev`, which isn't the format that `dev_name()` returns. I'm adding a fix to zed.dev as well: - https://github.com/zed-industries/zed.dev/pull/393 so that the values are adjusted for all clients, not just ones with this fix. I will correct the data in clickhouse, and adjust the queries in metabase. Release Notes: - N/A --- crates/zed/src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/zed/src/main.rs b/crates/zed/src/main.rs index 704eef464c223cadfaf152d54651456f0b9b2d70..12ae0f2ffce9709b5b9c45cb2b28053c5bf1f355 100644 --- a/crates/zed/src/main.rs +++ b/crates/zed/src/main.rs @@ -479,7 +479,7 @@ fn init_panic_hook(app: &App, installation_id: Option, session_id: Strin line: location.line(), }), app_version: app_version.clone(), - release_channel: RELEASE_CHANNEL.dev_name().into(), + release_channel: RELEASE_CHANNEL.display_name().into(), os_name: platform.os_name().into(), os_version: platform .os_version()