Fix search bar not closing on escape in Helix keymap (#48847)

buildingvibes , buildingvibes , and Jakub Konka created 3 weeks ago

Release Notes:

- Fixed an issue where pressing `Escape` in the search bar did not dismiss it when using the Helix keymap, while it worked correctly in Vim mode.

Co-authored-by: buildingvibes <[e-mail]>
Co-authored-by: Jakub Konka <[e-mail]>

Change summary

assets/keymaps/vim.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Detailed changes

assets/keymaps/vim.json

@@ -418,7 +418,7 @@
     },
   },
   {
-    "context": "VimControl && vim_mode == helix_normal && !menu",
+    "context": "VimControl && vim_mode == helix_normal && !menu && !BufferSearchBar",
     "bindings": {
       "j": ["vim::Down", { "display_lines": true }],
       "down": ["vim::Down", { "display_lines": true }],
@@ -436,7 +436,7 @@
     },
   },
   {
-    "context": "vim_mode == helix_select && !menu",
+    "context": "vim_mode == helix_select && !menu && !BufferSearchBar",
     "bindings": {
       "escape": "vim::SwitchToHelixNormalMode",
     },