From fb0af505538a11a90d254c89ae3727f124322b0a Mon Sep 17 00:00:00 2001 From: Conashimi <33379473+momota1029@users.noreply.github.com> Date: Tue, 10 Feb 2026 05:04:12 +0900 Subject: [PATCH] gpui: Allow OS caption/buttons for custom Windows titlebar (#48330) ## Summary Fixes an issue where GPUI's handling of `WM_NCLBUTTONDOWN` prevented Windows from processing default titlebar interactions (dragging, caption buttons, and border resize). ## Changes - Allow OS to handle `WM_NCLBUTTONDOWN` events for `HTCAPTION`, caption button areas, and resize border areas (`HTLEFT`, `HTRIGHT`, `HTTOP`, `HTBOTTOM`, `HTTOPLEFT`, `HTTOPRIGHT`, `HTBOTTOMLEFT`, `HTBOTTOMRIGHT`) - Use current cursor position in `WM_NCHITTEST` for accurate hit-testing ## Testing - Manual testing on Windows: titlebar dragging works - Manual testing on Windows: minimize/maximize/close buttons work - Manual testing on Windows: window border resize works in all directions Release Notes: - N/A --- crates/gpui/src/platform/windows/events.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/crates/gpui/src/platform/windows/events.rs b/crates/gpui/src/platform/windows/events.rs index f708c8ddb9cc87abbfe43bedbf96b74b15c2ad11..45bd3320c069f68fcf173b57662f9b843dd95cf9 100644 --- a/crates/gpui/src/platform/windows/events.rs +++ b/crates/gpui/src/platform/windows/events.rs @@ -958,8 +958,7 @@ impl WindowsWindowInner { click_count, first_mouse: false, }); - let result = func(input); - let handled = !result.propagate || result.default_prevented; + let handled = !func(input).propagate; self.state.callbacks.input.set(Some(func)); if handled {