From fb2c2c55dc7f5838baa4c31add38799f5d252db5 Mon Sep 17 00:00:00 2001 From: Julia Ryan Date: Wed, 5 Nov 2025 14:34:05 -0800 Subject: [PATCH] Fix windows crash handler (#42039) Closes #41471 We were killing the crash handler when it received a second copy of any of the messages, but this GPU specs one is sent on each new window rather than once at startup. We could gate the sending to only happen once, but it's simpler to just allow multiple gpu specs messages. Release Notes: - N/A --- crates/crashes/src/crashes.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/crates/crashes/src/crashes.rs b/crates/crashes/src/crashes.rs index 3a2c9378535dd1ac5dead68b3191ba1699b4d920..560ca5a009d5ddf8f3866591ebd9e6247bc98942 100644 --- a/crates/crashes/src/crashes.rs +++ b/crates/crashes/src/crashes.rs @@ -265,9 +265,10 @@ impl minidumper::ServerHandler for CrashServer { 3 => { let gpu_specs: system_specs::GpuSpecs = bincode::deserialize(&buffer).expect("gpu specs"); - self.active_gpu - .set(gpu_specs) - .expect("already set active gpu"); + // we ignore the case where it was already set because this message is sent + // on each new window. in theory all zed windows should be using the same + // GPU so this is fine. + self.active_gpu.set(gpu_specs).ok(); } _ => { panic!("invalid message kind");