diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index af8b41a5923e7ff4efc9329376342008f0aac77c..8ffdb566791e8f832ac6751c423edd4a1aa29e67 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -7096,22 +7096,13 @@ impl Editor { .line_comment_prefixes() .filter(|prefixes| !prefixes.is_empty()) { - // Split the comment prefix's trailing whitespace into a separate string, - // as that portion won't be used for detecting if a line is a comment. - struct Comment { - full_prefix: Arc, - trimmed_prefix_len: usize, - } - let prefixes: SmallVec<[Comment; 4]> = full_comment_prefixes + let first_prefix = full_comment_prefixes + .first() + .expect("prefixes is non-empty"); + let prefix_trimmed_lengths = full_comment_prefixes .iter() - .map(|full_prefix| { - let trimmed_prefix_len = full_prefix.trim_end_matches(' ').len(); - Comment { - trimmed_prefix_len, - full_prefix: full_prefix.clone(), - } - }) - .collect(); + .map(|p| p.trim_end_matches(' ').len()) + .collect::>(); let mut all_selection_lines_are_comments = true; @@ -7120,28 +7111,25 @@ impl Editor { continue; } - let Some((prefix, prefix_range)) = prefixes + let prefix_range = full_comment_prefixes .iter() - .map(|prefix| { - ( - prefix, - comment_prefix_range( - snapshot.deref(), - row, - &prefix.full_prefix[..prefix.trimmed_prefix_len], - &prefix.full_prefix[prefix.trimmed_prefix_len..], - ), + .zip(prefix_trimmed_lengths.iter().copied()) + .map(|(prefix, trimmed_prefix_len)| { + comment_prefix_range( + snapshot.deref(), + row, + &prefix[..trimmed_prefix_len], + &prefix[trimmed_prefix_len..], ) }) - .max_by_key(|(_, range)| range.end.column - range.start.column) - else { - // There has to be at least one prefix. - break; - }; + .max_by_key(|range| range.end.column - range.start.column) + .expect("prefixes is non-empty"); + if prefix_range.is_empty() { all_selection_lines_are_comments = false; } - selection_edit_ranges.push((prefix_range, prefix.full_prefix.clone())); + + selection_edit_ranges.push(prefix_range); } if all_selection_lines_are_comments { @@ -7149,17 +7137,17 @@ impl Editor { selection_edit_ranges .iter() .cloned() - .map(|(range, _)| (range, empty_str.clone())), + .map(|range| (range, empty_str.clone())), ); } else { let min_column = selection_edit_ranges .iter() - .map(|(range, _)| range.start.column) + .map(|range| range.start.column) .min() .unwrap_or(0); - edits.extend(selection_edit_ranges.iter().map(|(range, prefix)| { + edits.extend(selection_edit_ranges.iter().map(|range| { let position = Point::new(range.start.row, min_column); - (position..position, prefix.clone()) + (position..position, first_prefix.clone()) })); } } else if let Some((full_comment_prefix, comment_suffix)) = diff --git a/crates/editor/src/editor_tests.rs b/crates/editor/src/editor_tests.rs index d9a2ff4d034bf1c0ab3ff194e0159c16d2591a10..57aa7fc754595fec941ad4d1f01cef360160a7b3 100644 --- a/crates/editor/src/editor_tests.rs +++ b/crates/editor/src/editor_tests.rs @@ -6507,7 +6507,7 @@ async fn test_toggle_comment(cx: &mut gpui::TestAppContext) { let mut cx = EditorTestContext::new(cx).await; let language = Arc::new(Language::new( LanguageConfig { - line_comments: vec!["// ".into()], + line_comments: vec!["// ".into(), "//! ".into(), "/// ".into()], ..Default::default() }, Some(tree_sitter_rust::language()), @@ -6601,6 +6601,25 @@ async fn test_toggle_comment(cx: &mut gpui::TestAppContext) { // c();ˇ» } "}); + + // If a selection includes multiple comment prefixes, all lines are uncommented. + cx.set_state(indoc! {" + fn a() { + «// a(); + /// b(); + //! c();ˇ» + } + "}); + + cx.update_editor(|e, cx| e.toggle_comments(&ToggleComments::default(), cx)); + + cx.assert_editor_state(indoc! {" + fn a() { + «a(); + b(); + c();ˇ» + } + "}); } #[gpui::test] diff --git a/crates/languages/src/rust/config.toml b/crates/languages/src/rust/config.toml index e05234c774d17117de5cad142a778318e4de210e..d01f62e354ea483c634e16705603acf0c7e644f3 100644 --- a/crates/languages/src/rust/config.toml +++ b/crates/languages/src/rust/config.toml @@ -1,7 +1,7 @@ name = "Rust" grammar = "rust" path_suffixes = ["rs"] -line_comments = [ "/// ", "//! ", "// "] +line_comments = ["// ", "/// ", "//! "] autoclose_before = ";:.,=}])>" brackets = [ { start = "{", end = "}", close = true, newline = true },