From fd306c97f4129727174abd9a8e4224d3ba0a2d50 Mon Sep 17 00:00:00 2001 From: Abdelhakim Qbaich Date: Mon, 27 Oct 2025 17:57:04 -0400 Subject: [PATCH] Fix default settings entry for basedpyright (#40812) If you set `{"basedpyright": {"analysis": {"typeCheckingMode": "off"}}}`, you will notice that it doesn't actually work, but `{"basedpyright.analysis": {"typeCheckingMode": "off"}}` does. Made the change on how the default is being set. Release Notes: - N/A --- crates/languages/src/python.rs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/crates/languages/src/python.rs b/crates/languages/src/python.rs index c255ed3f09f733321c1066520b12355f76941931..f676f5a7a6f028c095d52273fb8c616472a35ee5 100644 --- a/crates/languages/src/python.rs +++ b/crates/languages/src/python.rs @@ -1866,12 +1866,8 @@ impl LspAdapter for BasedPyrightLspAdapter { } // Basedpyright by default uses `strict` type checking, we tone it down as to not surpris users maybe!({ - let basedpyright = object - .entry("basedpyright") - .or_insert(Value::Object(serde_json::Map::default())); - let analysis = basedpyright - .as_object_mut()? - .entry("analysis") + let analysis = object + .entry("basedpyright.analysis") .or_insert(Value::Object(serde_json::Map::default())); if let serde_json::map::Entry::Vacant(v) = analysis.as_object_mut()?.entry("typeCheckingMode")