From fdd233eea95688f065101fa9864abe944cddc089 Mon Sep 17 00:00:00 2001 From: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Date: Tue, 16 Jul 2024 09:40:40 -0300 Subject: [PATCH] Change the context menu and Copilot settings icon (#14501) Felt the link we were using for menu items that open a browser page was not the best. That one is most typically used for attachments within scope, as opposed to opening external links. Noticed that via the "Copilot Settings" menu, which also felt like it could have a bit more descriptive label. Also reduced the size of the rendered icon in this component. --- Release Notes: - N/A --- .../inline_completion_button/src/inline_completion_button.rs | 2 +- crates/ui/src/components/context_menu.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/inline_completion_button/src/inline_completion_button.rs b/crates/inline_completion_button/src/inline_completion_button.rs index d500b223e30999dba472f439a563d25bd4812247..1918481e41f14a699b251710bb1d8beff4897cc4 100644 --- a/crates/inline_completion_button/src/inline_completion_button.rs +++ b/crates/inline_completion_button/src/inline_completion_button.rs @@ -286,7 +286,7 @@ impl InlineCompletionButton { self.build_language_settings_menu(menu, cx) .separator() .link( - "Copilot Settings", + "Go to Copilot Settings", OpenBrowser { url: COPILOT_SETTINGS_URL.to_string(), } diff --git a/crates/ui/src/components/context_menu.rs b/crates/ui/src/components/context_menu.rs index 379f5a4a58f8ef66d453e7dbada222e38998457c..0c9b61f1f980c34708d78fe004e6e1584a9eb609 100644 --- a/crates/ui/src/components/context_menu.rs +++ b/crates/ui/src/components/context_menu.rs @@ -178,7 +178,7 @@ impl ContextMenu { action: Some(action.boxed_clone()), handler: Rc::new(move |_, cx| cx.dispatch_action(action.boxed_clone())), - icon: Some(IconName::Link), + icon: Some(IconName::ArrowUpRight), }); self } @@ -360,7 +360,7 @@ impl Render for ContextMenu { h_flex() .gap_1() .child(Label::new(label.clone())) - .child(Icon::new(*icon)) + .child(Icon::new(*icon).size(IconSize::Small)) .into_any_element() } else { Label::new(label.clone()).into_any_element()